[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/kdelirc
From:       Michael Zanetti <michael_zanetti () gmx ! net>
Date:       2010-03-03 21:57:00
Message-ID: 1267653420.069162.28252.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1098546 by mzanetti:

reworked notification. Notifying the user when a remote becomes available or \
unavailable seems enough. no need to tell about backend states


 M  +0 -1      TODO  
 M  +2 -5      kded/kremotecontroldaemon.cpp  


--- branches/work/kdelirc/TODO #1098545:1098546
@@ -1,7 +1,6 @@
 TODOs before move to kdereview
 -------------------------------
 * update docs (mzanetti)
-* rework nofications from Kded (mzanetti + frasche)
 * rework icons
 * knewstuff
 * more unit tests (can also be done after moving back to kdeutils)
--- branches/work/kdelirc/kded/kremotecontroldaemon.cpp #1098545:1098546
@@ -141,7 +141,6 @@
 
 void KRemoteControlDaemon::slotStatusChanged(bool connected) {
     if(connected){
-        notifyEvent(i18n("A connection to the remote control  subsystem has been \
made. Remote controls may now be available."));	  foreach(const QString &remote, \
RemoteControl::allRemoteNames()){  RemoteControl *rc = new RemoteControl(remote);
             kDebug() << "connecting to remote" << remote;
@@ -150,8 +149,6 @@
                     this,
                     SLOT(gotMessage(const Solid::Control::RemoteControlButton &)));
         }
-    } else {
-        notifyEvent(i18n("The remote control subsystem  has severed its connection. \
Remote controls are no longer available."));  }
     emit connectionChanged(connected);
 }
@@ -226,10 +223,10 @@
 void KRemoteControlDaemon::slotRemoteControlAdded(const QString& name) {
     if(d_ptr->getRemote(name)){
         kDebug() << "remote found";
-        notifyEvent(i18n("The remote %1 is now available.", name));
+        notifyEvent(i18n("The remote control %1 is now available.", name));
     }else{
         kDebug() << "remote not found";
-        KNotification *notification = KNotification::event("global_event", i18n("An \
unconfigured remote %1 is now available.", name), +        KNotification \
*notification = KNotification::event("global_event", i18n("An unconfigured remote \
                control %1 is now available.", name),
                   DesktopIcon("infrared-remote"), 0, KNotification::Persistant, \
                d_ptr->applicationData);      
         notification->setActions(QStringList() << i18nc("Configure the remote", \
                "Configure remote"));
         connect(notification, SIGNAL(activated(unsigned int)), \
SLOT(lauchKcmShell()));


[prev in list] [next in list] [prev in thread] [next in thread]