[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/graphics/kphotoalbum/ImportExport
From:       Jan Kundrát <jkt () gentoo ! org>
Date:       2010-02-24 17:13:45
Message-ID: 1267031625.769437.23836.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1095615 by jkt:

Fix Krazy/EBN warning baout braindead use of iterators

Thanks to Parkotron, maelcum|lap and other helful folks at #kde-devel for
spotting the inefficient use inside the loop.

 M  +3 -2      MD5CheckPage.cpp  


--- trunk/extragear/graphics/kphotoalbum/ImportExport/MD5CheckPage.cpp \
#1095614:1095615 @@ -58,8 +58,9 @@
     createRow( grid, row, QString::fromLatin1("*Description*"), i18n("Description"), \
                clashes.description, true);
     createRow( grid, row, QString::fromLatin1( "*Orientation*" ), \
                i18n("Orientation"), clashes.orientation, false );
     createRow( grid, row, QString::fromLatin1( "*Date*" ), i18n("Date and Time"), \
                clashes.date, false );
-    Q_FOREACH( const QString& category, clashes.categories.keys() )
-        createRow( grid, row, category, category, clashes.categories[category], true \
); +    for ( QMap<QString,bool>::const_iterator it = clashes.categories.begin(); it \
!= clashes.categories.end(); ++it ) { +        createRow( grid, row, it.key(), \
it.key(), *it, true ); +    }
 
     vlay->addStretch(1);
 }


[prev in list] [next in list] [prev in thread] [next in thread]