[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/rendering
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2010-02-12 4:20:38
Message-ID: 1265948438.687577.10917.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1088980 by ggarand:

great, looks like these two Qt regressions have finally been fixed,
so we can enable back the optimized code and close all the printing bugs
that closing/restoring the QPainter triggered

I'll do that in two commits so that problems can be pin-pointed :

2) stop forcing the buffering of widgets, and directly render() widgets
 in-place when possible (i.e. there's no scaling, and we aren't printing).

 M  +1 -5      render_replaced.cpp  


--- trunk/KDE/kdelibs/khtml/rendering/render_replaced.cpp #1088979:1088980
@@ -736,11 +736,7 @@
     QPainter* const p = pI.p;
     allowWidgetPaintEvents = true;
 
-    // Qt 4.4 regression #2: 
-    //    can't use QWidget::render to directly paint widgets on the view anymore.
-    //    Results are unreliable for subrects, leaving blank squares. (cf. kde \
                #158607)
-    //
-    bool buffered = true; // p->combinedMatrix().m22() != 1.0 || \
(p->device()->devType() == QInternal::Printer); +    bool buffered = \
p->combinedMatrix().m22() != 1.0 || (p->device()->devType() == QInternal::Printer);  
     QRect rr = pI.r;
     rr.translate(-tx, -ty);


[prev in list] [next in list] [prev in thread] [next in thread]