[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/blogilo/src
From:       Christian Weilbach <christian () whiletaker ! homeip ! net>
Date:       2010-02-10 23:36:52
Message-ID: 1265845012.708420.27320.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1088488 by weilbach:

Fix bug 225124 and cleanups.
CCBUG 225124

Not a clean fix as I don't understand all the pointer stuff in the backend. Don't \
know how the BlogPost can get deleted before slotFetchedPost is called in GData, but \
it seems to be this line.


 M  +3 -1      backend.cpp  
 M  +2 -3      composer/stylegetter.cpp  


--- trunk/KDE/kdepim/blogilo/src/backend.cpp #1088487:1088488
@@ -422,7 +422,9 @@
         kDebug() << "Emitting sigPostPublished ...";
         Q_EMIT sigPostPublished( mBBlog->id(), pp );
     }
-    delete post;
+    // TODO crashes stylegetter on GData. Somehow the post gets deleted before
+    // slotFetchedPost as it seems. Don't get all the pointer copies done here.
+    //delete post;
 }
 
 KBlog::BlogPost * Backend::preparePost( BilboPost &post )
--- trunk/KDE/kdepim/blogilo/src/composer/stylegetter.cpp #1088487:1088488
@@ -82,7 +82,6 @@
     b = new Backend( blogid );
     connect( b, SIGNAL( sigPostPublished( int, BilboPost* ) ), this,
              SLOT( sltTempPostPublished( int, BilboPost* ) ) );
-//     connect( b, SIGNAL( sigPostFetched( BilboPost * ) ), this, SLOT( \
                sltTempPostFetched( BilboPost * ) ) );
     connect( b, SIGNAL( sigError( const QString& ) ), this, SLOT( sltError( const \
QString& ) ) );  
     Q_EMIT sigGetStyleProgress( 10 );
@@ -160,9 +159,9 @@
 
     mTempPost = post;
     KIO::StoredTransferJob *job = KIO::storedGet( postUrl, KIO::NoReload, \
                KIO::HideProgressInfo );
-
     connect( job, SIGNAL( result( KJob* ) ),
             this, SLOT( sltHtmlCopied( KJob* ) ) );
+
 }
 
 void StyleGetter::sltHtmlCopied( KJob *job )
@@ -212,9 +211,9 @@
 
 
     //Remove temp post from the server.
-    b->removePost( *mTempPost );
     connect( b, SIGNAL( sigPostRemoved( int, const BilboPost &) ), this,
              SLOT( sltTempPostRemoved( int, const BilboPost & ) ) );
+    b->removePost( *mTempPost );
 }
 
 void StyleGetter::sltTempPostRemoved( int blog_id, const BilboPost &post)


[prev in list] [next in list] [prev in thread] [next in thread]