[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kio/kio
From:       Andreas Hartmetz <ahartmetz () gmail ! com>
Date:       2010-02-07 13:57:08
Message-ID: 1265551028.750591.18993.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1086499 by ahartmetz:

KIO is not thread-safe, KRunner plugin writers take note.

 M  +3 -0      scheduler.cpp  


--- trunk/KDE/kdelibs/kio/kio/scheduler.cpp #1086498:1086499
@@ -894,6 +894,8 @@
 void SchedulerPrivate::doJob(SimpleJob *job)
 {
     kDebug(7006) << job;
+    Q_ASSERT(QThread::currentThread() == QCoreApplication::instance()->thread());
+
     KIO::SimpleJobPrivate *const jobPriv = SimpleJobPrivate::get(job);
     jobPriv->m_protocol = KProtocolManager::slaveProtocol(job->url(), jobPriv->m_proxy);
 
@@ -939,6 +941,7 @@
 void SchedulerPrivate::jobFinished(SimpleJob *job, Slave *slave)
 {
     kDebug(7006) << job << slave;
+    Q_ASSERT(QThread::currentThread() == QCoreApplication::instance()->thread());
     KIO::SimpleJobPrivate *const jobPriv = SimpleJobPrivate::get(job);
     // make sure that we knew about the job!
     Q_ASSERT(jobPriv->m_schedSerial);
[prev in list] [next in list] [prev in thread] [next in thread]