[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/4.4/kdelibs/nepomuk/core
From:       David Faure <faure () kde ! org>
Date:       2010-02-05 17:33:31
Message-ID: 201002051833.31856.faure () kde ! org
[Download RAW message or body]

On Friday 05 February 2010, Sebastian Trüg wrote:
> That is bad indeed. I know the code is very very inefficient. But
> without the hack the thing crashes. Especially Strigi crashes all the
> time after indexing N files. 

... and with the hack, the whole desktop is unusable after a few hours.
Laurent was experiencing the same, and confirms that reverting this
commit fixes the problem for him too. If it misbehaves, the user can disable 
strigi, but the user cannot disable the whole desktop ;)

> This is also related to the DBus bug which
> causes so many problems. It would be great if Thiago could work around
> that in QtDBus. Then such hacks would be unnecessary. Without a
> workaround I do not really know what to do here...

Well, how about creating one connection per thread, rather than one per 
request, at least?
Maybe QThreadStorage can help with implementing that, otherwise
a QMap<QThread*, QDbusConnection*> and a mutex around the map.

kde-4.4.0 is almost released, so at this point even a workaround in QtDBus 
wouldn't help our users much.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

[prev in list] [next in list] [prev in thread] [next in thread]