[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: branches/KDE/4.4/kdelibs/kio/kio
From: Dawit Alemayehu <adawit () kde ! org>
Date: 2010-02-03 21:24:56
Message-ID: 201002031624.56552.adawit () kde ! org
[Download RAW message or body]
On Wednesday 03 February 2010 14:25:05 you wrote:
> > It is unfortunate that you commented out that code because it was
> > explicitly designed to deal with the bug report by simply modifying the
> > "maxInstances" and "maxInstancesPerHost" in the appropriate ".protocol
> > files" or removing the latter altogether (not recommended) to get the
> > previous no limits mode.
> >
> > Simply changing these values to whatever higher number you use demands
> > would have automatically solved the problem without any need to
> > disable/change code. Right now for http ioslave these values are 20 and 5
> > respectively which is probably not sufficient for some use cases, but
> > without getting the details for that and disabling this code is a mistake,
> > specially since the fix for it would not require any code changes...
> Huh? If the code is correct, it should function with limits as low as 1/1,
> just relatively slowly. It should not needlessly burn CPU, and eventually
> load everything regardless of settings. Playing with numbers is no fix.
Fair enough... The limits should not result in 100% CPU cycles. But then the
workaround to the original workaround is not to disable it entirely because it
too was a workaround for other issues. Anyhow, I will fix the issue of CPU
spinning when the limits are drastically low. It is unfortunate that people
ignored my plea for testing this stuff when I originally posted it on
reviewboard a long time back. *sigh*
Oh please CC me on any response since I am not subscribed to receive the kde-
commits list.
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Sans Serif'; font-size:9pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">On Wednesday 03 February 2010 14:25:05 you wrote:</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > It is unfortunate \
that you commented out that code because it was</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> > explicitly designed to deal with the \
bug report by simply modifying the</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> > "maxInstances" and \
"maxInstancesPerHost" in the appropriate ".protocol</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > files" or \
removing the latter altogether (not recommended) to get the</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > previous no limits \
mode.</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > \
</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > Simply changing \
these values to whatever higher number you use demands</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> > would have automatically solved the \
problem without any need to</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> > disable/change code. Right now for http ioslave these \
values are 20 and 5</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> > respectively which is probably not sufficient for some \
use cases, but</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > \
without getting the details for that and disabling this code is a mistake,</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > specially since the \
fix for it would not require any code changes...</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;">> Huh? If the \
code is correct, it should function with limits as low as 1/1,</span></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;">> just \
relatively slowly. It should not needlessly burn CPU, and eventually</span></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;">> load \
everything regardless of settings. Playing with numbers is no fix.</span></p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0; \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;">Fair enough... \
The limits should not result in 100% CPU cycles. But then the workaround to the \
original workaround is not to disable it entirely because it too was a workaround for \
other issues. Anyhow, I will fix the issue of CPU spinning when the limits are \
drastically low. It is unfortunate that people ignored my plea for testing this stuff \
when I originally posted it on reviewboard a long time back. *sigh*</span></p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0; \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" \
font-family:'bitstream vera sans'; font-size:medium; color:#000000;">Oh please CC me \
on any response since I am not subscribed to receive the kde-commits \
list.</span></p></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic