[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/4.4/kdelibs/kio/kio
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2010-02-03 19:25:05
Message-ID: 201002031425.05923.adawit () kde ! org
[Download RAW message or body]

It is unfortunate that you commented out that code because it was explicitly 
designed to deal with the  bug report by simply modifying the "maxInstances" 
and "maxInstancesPerHost" in the appropriate ".protocol files" or removing the 
latter altogether (not recommended) to get the previous no limits mode.

Simply changing these values to whatever higher number you use demands would 
have automatically solved the problem without any need to disable/change code. 
Right now for http ioslave these values are 20 and 5 respectively which is 
probably not sufficient for some use cases, but without getting the details 
for that and disabling this code is a mistake, specially since the fix for it 
would not require any code changes...


On Wednesday 03 February 2010 11:38:48 Maks Orlovich wrote:
> SVN commit 1084737 by orlovich:
> 
> The connection limit is clearly broken --- once we hit it,
> the scheduler spins at 100% CPU (startTimer(0)?) and doesn't
> appear to actually make any progress, either. So, disable
> this for 4.4.0 (if I made it) as a workaround.
> 
> Might want to consider using the scheduler from trunk for 4.4.1...
> 
> CCMAIL: adawit@kde.org
> BUG: 224857
> 
> 
>  M  +2 -1      scheduler.cpp
> 
> 
> --- branches/KDE/4.4/kdelibs/kio/kio/scheduler.cpp #1084736:1084737
> @@ -744,7 +744,8 @@
>  {
>      Slave *slave = 0;
> 
> -    if (!enforceLimits || checkLimits(protInfo, job))
> +    if (true /* ### temporary workaround for #224857*/ ||
> +        !enforceLimits || checkLimits(protInfo, job))
>      {
>          KIO::SimpleJobPrivate *const jobPriv = SimpleJobPrivate::get(job);
[prev in list] [next in list] [prev in thread] [next in thread]