[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.4/kdelibs/khtml/rendering
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2010-02-01 20:19:58
Message-ID: 1265055598.272446.13687.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1083714 by ggarand:

Backport this nasty RC3 regression fix ;-(
----------
automatically merged revision 1083713:
fix nasty regression noticed by Tommi.
This event filter was being installed recursively, causing linedit
completion popups to appear corrupted.

CCBUG: 216795

 M  +5 -3      render_form.cpp  


--- branches/KDE/4.4/kdelibs/khtml/rendering/render_form.cpp #1083713:1083714
@@ -997,9 +997,10 @@
     bool showClearButton = (!shouldPaintBorder() && !_style->hasBackgroundImage());
     static_cast<LineEditWidget*>(widget())->setClearButtonShown( showClearButton );
     if (showClearButton) {
-        QList<QWidget *> wl = qFindChildren<QWidget *>(m_widget, QString());
-        foreach (QWidget* w, wl)
-            if (!w->isWindow()) {
+        QObjectList children = widget()->children();
+        foreach (QObject* object, children) {
+            QWidget *w = qobject_cast<QWidget*>(object);
+            if (w && !w->isWindow()) {
                 // this duplicates KHTMLView's handleWidget but this widget 
                 // is created on demand, so it might not be here at ChildPolished time
                 w->setObjectName("KHTMLLineEditButton");
@@ -1008,6 +1009,7 @@
                 w->setAttribute(Qt::WA_WState_InPaintEvent);
                 w->setAttribute(Qt::WA_OpaquePaintEvent);
             }
+        }
     }
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]