[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/filters/libkowmf
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2010-01-20 9:24:43
Message-ID: 1263979483.973250.7578.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1077448 by ingwa:

Fix a background bug that manifested itself rather seldomly.


 M  +11 -2     kowmfpaint.cc  


--- trunk/koffice/filters/libkowmf/kowmfpaint.cc #1077447:1077448
@@ -149,6 +149,10 @@
 
 void KoWmfPaint::setTextPen(const QPen &pen)
 {
+#if DEBUG_WMFPAINT
+    kDebug(31000) << pen;
+#endif
+
     mTextPen = pen;
 }
 
@@ -213,8 +217,13 @@
     // FIXME: This needs more investigation, but it seems that the
     //        concept of "background" in WMF is the same as the
     //        "brush" in QPainter.
-    mPainter->setBrush(QBrush(c));
-    //mPainter->setBackground(QBrush(c));
+    // Update: No, it wasn't.  I changed back now because it didn't work.  I'm leaving
+    //         the fixme and this comment to remind the next fixer that calling
+    //         setBrush() is not the solution.  I hope nothing breaks now.
+    //         The date is now 2010-01-20.  If nothing breaks in a couple of months,
+    //         all this commentry can be removed.
+    //mPainter->setBrush(QBrush(c));
+    mPainter->setBackground(QBrush(c));
 }
 
 
[prev in list] [next in list] [prev in thread] [next in thread]