[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeplasma-addons/applets
From:       Jonathan Michael Thomas <echidnaman () kubuntu ! org>
Date:       2010-01-10 19:38:37
Message-ID: 1263152317.491638.1498.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1072712 by jmthomas:

Fix a few dialogs that Krazy considers crashy


 M  +4 -3      comic/comic.cpp  
 M  +4 -3      frame/frame.cpp  
 M  +4 -3      paste/snippetconfig.cpp  


--- trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp #1072711:1072712
@@ -596,10 +596,11 @@
 void ComicApplet::slotGoJump()
 {
     if ( mSuffixType == "Number" ) {
-        ChooseStripNumDialog pageDialog( 0, mCurrentIdentifierSuffix.toInt(), \
                mFirstStripNum[ mComicIdentifier ], mMaxStripNum[ mComicIdentifier ] \
                );
-        if ( pageDialog.exec() == QDialog::Accepted ) {
-            updateComic( QString::number( pageDialog.getStripNumber() ) );
+        QPointer<ChooseStripNumDialog> pageDialog = new ChooseStripNumDialog( 0, \
mCurrentIdentifierSuffix.toInt(), mFirstStripNum[ mComicIdentifier ], mMaxStripNum[ \
mComicIdentifier ] ); +        if ( pageDialog->exec() == QDialog::Accepted ) {
+            updateComic( QString::number( pageDialog->getStripNumber() ) );
         }
+        delete pageDialog;
         slotStartTimer();
     } else if ( mSuffixType == "Date" ) {
         KDatePicker *calendar = new KDatePicker;
--- trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp #1072711:1072712
@@ -387,14 +387,15 @@
 
 void Frame::addDir()
 {
-    KDirSelectDialog dialog(KUrl(), true);
-    if (dialog.exec()) {
-        QString path = dialog.url().url();
+    QPointer<KDirSelectDialog> dialog = new KDirSelectDialog(KUrl(), true);
+    if (dialog->exec()) {
+        QString path = dialog->url().url();
         if (!m_slideShowPaths.contains(path)) {
             m_configDialog->imageUi.slideShowDirList->addItem(path);
         }
         updateButtons();
     }
+    delete dialog;
 }
 
 void Frame::removeDir()
--- trunk/KDE/kdeplasma-addons/applets/paste/snippetconfig.cpp #1072711:1072712
@@ -84,10 +84,11 @@
 
 void SnippetConfig::addMacroClicked()
 {
-    AddMacro dlg(this);
-    if (dlg.exec() == QDialog::Accepted) {
-        textEdit->insertPlainText(dlg.macro());
+    QPointer<AddMacro> dlg = new AddMacro(this);
+    if (dlg->exec() == QDialog::Accepted) {
+        textEdit->insertPlainText(dlg->macro());
     }
+    delete dlg;
 }
 
 void SnippetConfig::removeClicked()


[prev in list] [next in list] [prev in thread] [next in thread]