[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdecore/services
From:       David Faure <faure () kde ! org>
Date:       2010-01-07 19:58:41
Message-ID: 1262894321.336290.8705.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1071275 by dfaure:

Show more info about the servicetype that is not found, and remove the assert.
So, if anyone still has issues with a servicetype (e.g. an okular plugin not being found),
include the output of the application, not just the backtrace.
CCBUG: 169027
CCBUG: 181350
Fixed for: 4.4


 M  +5 -1      kmimetypetrader.cpp  


--- trunk/KDE/kdelibs/kdecore/services/kmimetypetrader.cpp #1071274:1071275
@@ -87,7 +87,11 @@
 static void filterMimeTypeOffers(KServiceOfferList& list, const QString& genericServiceType)
 {
     KServiceType::Ptr genericServiceTypePtr = KServiceType::serviceType(genericServiceType);
-    Q_ASSERT(genericServiceTypePtr);
+    if (!genericServiceTypePtr) {
+        kError(7014) << "KMimeTypeTrader: couldn't find service type" << genericServiceType <<
+            "\nPlease ensure that the .desktop file for it is installed; then run kbuildsycoca4.";
+        return;
+    }
 
     QMutableListIterator<KServiceOffer> it(list);
     while(it.hasNext()) {
[prev in list] [next in list] [prev in thread] [next in thread]