[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdenetwork
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2010-01-03 19:48:28
Message-ID: 201001031748.39382.kubito () gmail ! com
[Download RAW message or body]

On Sunday 03 January 2010 17:39:50 Alexander Neundorf wrote:
> On Saturday 02 January 2010, Raphael Kubo da Costa wrote:
> > SVN commit 1069047 by rkcosta:
> > 
> > Disable kppp on FreeBSD. It has been broken with FreeBSD >= 8.0, so it's
> > better to just disable it until someone steps up to fix it.
> > 
> > FreeBSD porters, the Makefile for kdenetwork4 will need to be changed
> > from 4.4 RC1 on.
> > 
> > CCMAIL: kde-buildsystem@kde.org
> > CCMAIL: kde-freebsd@kde.org
> > 
> >  M  +6 -1      CMakeLists.txt
> > 
> > --- trunk/KDE/kdenetwork/CMakeLists.txt #1069046:1069047
> > @@ -75,8 +75,13 @@
> > 
> >  if(Q_WS_X11)
> >  
> >    macro_optional_add_subdirectory(krdc)
> > 
> > -  macro_optional_add_subdirectory(kppp)
> > 
> > +  # kppp is broken on FreeBSD >= 8.0
> > +  # disabling until a fix appears
> > +  if(NOT CMAKE_SYSTEM_NAME MATCHES FreeBSD)
> > +    macro_optional_add_subdirectory(kppp)
> > +  endif(NOT CMAKE_SYSTEM_NAME MATCHES FreeBSD)
> > +
> > 
> >    if(LIBVNCSERVER_FOUND)
> >    
> >      macro_optional_add_subdirectory(krfb)
> >    
> >    endif(LIBVNCSERVER_FOUND)
> 
> The following should also work (this sets the default value of the option
> for the kppp subdir to false):
> 
> if(CMAKE_SYSTEM_NAME MATCHES FreeBSD)
>    set(BUILD_kppp FALSE)
> endif(CMAKE_SYSTEM_NAME MATCHES FreeBSD)
> ...
> macro_optional_add_subdirectory(kppp)
> 
> Can you please check ?
> Maybe this would make getting it fixed easier.
> 
> Alex

I can change that if you want, but I fail to understand how it would make the 
fix any easier.
[prev in list] [next in list] [prev in thread] [next in thread]