[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepimlibs/mailtransport
From:       Thomas McGuire <mcguire () kde ! org>
Date:       2009-12-31 18:18:40
Message-ID: 1262283520.780412.11250.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1068278 by tmcguire:

API fixes: dueDate -> sendAfter


 M  +3 -3      dispatchmodeattribute.cpp  
 M  +3 -5      dispatchmodeattribute.h  
 M  +1 -1      messagequeuejob.cpp  
 M  +2 -2      tests/attributetest.cpp  


--- trunk/KDE/kdepimlibs/mailtransport/dispatchmodeattribute.cpp #1068277:1068278
@@ -47,7 +47,7 @@
 DispatchModeAttribute *DispatchModeAttribute::clone() const
 {
   DispatchModeAttribute * const cloned = new DispatchModeAttribute( d->mMode );
-  cloned->setDueDate( d->mDueDate );
+  cloned->setSendAfter( d->mDueDate );
   return cloned;
 }
 
@@ -102,12 +102,12 @@
   d->mMode = mode;
 }
 
-QDateTime DispatchModeAttribute::dueDate() const
+QDateTime DispatchModeAttribute::sendAfter() const
 {
   return d->mDueDate;
 }
 
-void DispatchModeAttribute::setDueDate( const QDateTime &date )
+void DispatchModeAttribute::setSendAfter( const QDateTime &date )
 {
   d->mDueDate = date;
 }
--- trunk/KDE/kdepimlibs/mailtransport/dispatchmodeattribute.h #1068277:1068278
@@ -76,19 +76,17 @@
     */
     void setDispatchMode( DispatchMode mode );
 
-    //TODO_AKONADI_REVIEW: Rename to sendAfter
     /**
       Returns the date and time when the message should be sent.
-      Only valid if dispatchMode() is AfterDueDate.
+      Only valid if dispatchMode() is Automatic.
     */
-    QDateTime dueDate() const;
+    QDateTime sendAfter() const;
 
-    //TODO_AKONADI_REVIEW: Rename to setSendAfter
     /**
       Sets the date and time when the message should be sent.
       @see setDispatchMode.
     */
-    void setDueDate( const QDateTime &date );
+    void setSendAfter( const QDateTime &date );
 
   private:
     class Private;
--- trunk/KDE/kdepimlibs/mailtransport/messagequeuejob.cpp #1068277:1068278
@@ -142,7 +142,7 @@
   AddressAttribute *addrA = new AddressAttribute( from, to, cc, bcc );
   DispatchModeAttribute *dmA = new DispatchModeAttribute( dispatchMode );
   if ( dueDate.isValid() )
-    dmA->setDueDate( dueDate );
+    dmA->setSendAfter( dueDate );
   SentBehaviourAttribute *sA = new SentBehaviourAttribute( sentBehaviour, moveToCollection );
   TransportAttribute *tA = new TransportAttribute( transport );
   item.addAttribute( addrA );
--- trunk/KDE/kdepimlibs/mailtransport/tests/attributetest.cpp #1068277:1068278
@@ -93,13 +93,13 @@
     int ms = date.toString( "z" ).toInt();
     date = date.addMSecs( -ms );
     DispatchModeAttribute *a = new DispatchModeAttribute( mode );
-    a->setDueDate( date );
+    a->setSendAfter( date );
     QByteArray data = a->serialized();
     delete a;
     a = new DispatchModeAttribute;
     a->deserialize( data );
     QCOMPARE( mode, a->dispatchMode() );
-    QCOMPARE( date, a->dueDate() );
+    QCOMPARE( date, a->sendAfter() );
   }
 
   {
[prev in list] [next in list] [prev in thread] [next in thread]