[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/akonadi-ports/kdepim/kmail (silent)
From:       Till Adam <till () kdab ! com>
Date:       2009-12-22 18:26:45
Message-ID: 200912221926.45323.till () kdab ! com
[Download RAW message or body]

On Tuesday 22 December 2009 14:58:31 Laurent Montel wrote:
> SVN commit 1065091 by mlaurent:
> 
> SVN_SILENT: minor
> 
> 
>  M  +7 -3      kmfilter.cpp
> 
> 
> --- branches/work/akonadi-ports/kdepim/kmail/kmfilter.cpp #1065090:1065091
> @@ -455,9 +455,13 @@
>  #if 0 // TODO: port to Akonadi
>        if ( mAccounts.isEmpty() )
>          result += " None";
> -      else for ( it2 = mAccounts.begin() ; it2 != mAccounts.end() ; ++it2
>  ) -        if ( kmkernel->acctMgr()->find( *it2 ) )
> -          result += ' ' + kmkernel->acctMgr()->find( *it2 )->name();
> +      else {
> +        for ( it2 = mAccounts.begin() ; it2 != mAccounts.end() ; ++it2 ) {
> +          if ( kmkernel->acctMgr()->find( *it2 ) ) {
> +            result += ' ' + kmkernel->acctMgr()->find( *it2 )->name();

Isn't acctMgr->find() O(n)? In that case, we should avoid calling it twice.

Till

-- 
Till Adam | till@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
[prev in list] [next in list] [prev in thread] [next in thread]