[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/runtime/drkonqi
From:       Darío Andrés Rodríguez <andresbajotierra () gmail ! co
Date:       2009-11-30 21:54:41
Message-ID: 1259618081.771945.29991.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1056802 by darioandres:

- Minor cleanup (remove some FIXME comments)
- If a selected report is marked as duplicate and DrKonqi asks the user which reports \
want to view, restore the cursor  (from "waiting" to "simple pointer")



 M  +1 -1      bugzillalib.cpp  
 M  +0 -1      reportassistantpages_bugzilla.cpp  
 M  +7 -7      reportassistantpages_bugzilla_duplicates.cpp  


--- trunk/KDE/kdebase/runtime/drkonqi/bugzillalib.cpp #1056801:1056802
@@ -735,7 +735,7 @@
 
 void BugzillaUploadData::attachFile(const QString & url, const QString & \
description)  {
-    //FIXME implement
+    //TODO implement when needed
     //Read file contents and use attachRawData
     Q_UNUSED(url);
     Q_UNUSED(description);
--- trunk/KDE/kdebase/runtime/drkonqi/reportassistantpages_bugzilla.cpp \
#1056801:1056802 @@ -373,7 +373,6 @@
 {
     checkTexts();
 
-    //FIXME improve logic according to the info the user can provide
     if (m_textsOK) { //not empty
         bool titleShort = ui.m_titleEdit->text().size() < 30;
 
--- trunk/KDE/kdebase/runtime/drkonqi/reportassistantpages_bugzilla_duplicates.cpp \
#1056801:1056802 @@ -208,17 +208,15 @@
         endDateStr = QLatin1String("Now");
     }
 
+#if true
     BugReport report = reportInterface()->newBugReportTemplate();
     bugzillaManager()->searchBugs(reportInterface()->relatedBugzillaProducts(),
                                   report.bugSeverity(), startDateStr, endDateStr, 
                                   \
                reportInterface()->firstBacktraceFunctions().join(" "));
-
-    //Test search
-    /*
-    bugzillaManager()->searchBugs(QStringList() << "plasma", "crash",
-                startDateStr, endDateStr,
-       "QGraphicsScenePrivate::processDirtyItemsRecursive \
                QGraphicsScenePrivate::_q_processDirtyItems");
-    */
+#else //Test search
+    bugzillaManager()->searchBugs(QStringList() << "plasma", "crash", startDateStr, \
endDateStr, +       "QGraphicsScenePrivate::processDirtyItemsRecursive");
+#endif
 }
 
 void BugzillaDuplicatesPage::stopCurrentSearch()
@@ -571,6 +569,8 @@
                 bool ok = false;
                 int dupId = duplicate.toInt(&ok);
                 if (ok && dupId > 0) {
+                    ui.m_statusWidget->setIdle(QString());
+
                     KGuiItem yesItem = KStandardGuiItem::yes();
                     yesItem.setText(i18nc("@action:button let the user to choose to \
read the "  "main report", "Yes, read the main report"));


[prev in list] [next in list] [prev in thread] [next in thread]