[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/klipper
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2009-11-30 10:11:14
Message-ID: 200911301111.14413.l.lunak () suse ! cz
[Download RAW message or body]

On Saturday 28 of November 2009, Esben Mose Hansen wrote:
> SVN commit 1055587 by esben:
>
> Remove old XFixes support, which is now supported directly by QClipboard.
> Also doubles the timeout for checking whether the clipboard is empty, to
> avoid false positives. BUG: 166606

> bool clipEmpty = data->formats().isEmpty();
> +    if (clipEmpty) {
> +        // Might be a timeout. Try again
> +        clipEmpty = data->formats().isEmpty();
> +#ifdef NOISY_KLIPPER
> +        kDebug() << "was empty. Retried, now " << (clipEmpty?" still
> empty":" no longer empty"); +#endif
> +    }

 I would have to check to be sure, but I think this is not doubling the 
timeout, it's keeping the old timeout and trying it twice. Have you tried if 
it actually makes a difference?

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 084 672
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz
[prev in list] [next in list] [prev in thread] [next in thread]