[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/graphics/kphotoalbum/AnnotationDialog
From:       Hassan Ibraheem <hasan.ibraheem () gmail ! com>
Date:       2009-11-30 8:06:06
Message-ID: 3109f2250911300006r4b5dc9fay66e538713c692e76 () mail ! gmail ! com
[Download RAW message or body]

2009/11/30 Jan Kundrát <jkt@gentoo.org>:
> Hassan Ibraheem wrote:
>> -    _optionList.setAutoDelete( true );
>
> Hi, I don't see any qDeleteAll() in the patch. I haven't looked at the
> code, but are you sure you do not leak memory here?
>
> Cheers,
> -jkt
>
> --
> cd /local/pub && more beer > /dev/mouth
>
>
I thought about that, and as far as I understood, we don't call any of
the Q3PtrList methods listed here about replacing setAutoDelete:
http://qt.nokia.com/doc/4.5/porting4.html#qptrlist-t
We don't remove/replace items from that list anywhere in the code.
However, maybe I should create a clear() method to be called before the
delete _annotationDialog;
in MainWindow/Window.cpp



-- 
Hassan Ibraheem

[prev in list] [next in list] [prev in thread] [next in thread]