[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE
From:       Fredrik =?iso-8859-1?q?H=F6glund?= <fredrik () kde ! org>
Date:       2009-11-26 23:52:08
Message-ID: 200911270052.08851.fredrik () kde ! org
[Download RAW message or body]

On Friday 27 November 2009, Andreas Pakulat wrote:
> On 26.11.09 14:37:16, Aaron J. Seigo wrote:
> > On November 26, 2009, Andreas Pakulat wrote:
> > > On 26.11.09 21:57:37, Marco Martin wrote:
> > > > SVN commit 1054830 by mart:
> > > >
> > > > move halopainter unchanged in libplasma, keep it private and expose
> > > > drawhalo in PaintUtils
> > > > iconwidgets uses it if there is no backgroundcolor explicitly setted
> > > > CCMAIL:fredrik@kde.org
> > > 
> > > Its a bit late for such commits, isn't it? Technically its a new feature
> > 
> > it's a move of existing code into a place it can be used by other code to fix 
> > a bug (in this case, text on dark wallpapers). so it's not a new feature, it's 
> > moving an existing one, and it addresses a bug (one we have reports on b.k.o 
> > for actually)
> 
> Granted about the bug, but IMHO its still a new feature as we track
> features on a per module basis. But enough nitpicking 

I think you need to remember that the reason we have the feature freeze is:

* To give the documentation team a chance to document the new features,
  and the translators a chance to translate the documentation.

* To focus on fixing bugs and stabilizing trunk, and not introduce new bugs
  by pushing new and untested code into SVN.

This isn't something that needs to be documented, it doesn't add new code,
and it fixes a bug. So therefore it isn't a problem.

Regards,
Fredrik

[prev in list] [next in list] [prev in thread] [next in thread]