[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/xml
From:       Maks Orlovich <maksim () kde ! org>
Date:       2009-11-18 20:11:53
Message-ID: 1258575113.204490.4815.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1051076 by orlovich:

Fix assert fail when cloneNode is called on an entry with dirty 
inline style information but no attribute map created yet 
(happens e.g. on the dot)

BUG:214662
BUG:215115


 M  +2 -2      dom_elementimpl.cpp  


--- trunk/KDE/kdelibs/khtml/xml/dom_elementimpl.cpp #1051075:1051076
@@ -5,7 +5,7 @@
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
-  *          (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
+ *           (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2005, 2008 Maksim Orlovich (maksim@kde.org)  
  *           (C) 2006 Allan Sandfeld Jensen (kde@carewolf.com)
  *
@@ -586,7 +586,7 @@
 void ElementImpl::finishCloneNode( ElementImpl* clone, bool deep )
 {
     // clone attributes
-    if (namedAttrMap)
+    if (namedAttrMap || m_needsStyleAttributeUpdate)
 	clone->attributes()->copyAttributes(attributes(true));
 
     assert( !m_needsStyleAttributeUpdate ); // ensured by previous line
[prev in list] [next in list] [prev in thread] [next in thread]