[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform/vcs
From:       David Nolden <zwabel () googlemail ! com>
Date:       2009-11-16 8:12:39
Message-ID: 200911160912.39060.zwabel () googlemail ! com
[Download RAW message or body]

Am Montag 16 November 2009 00:23:32 schrieb Andreas Pakulat:
> SVN commit 1049825 by apaku:
> 
> Don't try to show a widget if no job could be created.
> BUG:212196
> 
>  M  +3 -0      vcspluginhelper.cpp
> 
> 
> --- trunk/KDE/kdevplatform/vcs/vcspluginhelper.cpp #1049824:1049825
> @@ -268,6 +268,9 @@
>  {
>      SINGLEURL_SETUP_VARS
>      KDevelop::VcsJob *job = iface->log(url);
> +    if( !job ) {
> +        kWarning() << "Couldn't create log job for:" << url << "with
>  iface:" << iface << dynamic_cast<KDevelop::IPlugin*>( iface ); +    }
>      KDialog* dlg = new KDialog();
>      dlg->setButtons(KDialog::Close);
>      dlg->setCaption(i18n("%2 History (%1)", url.pathOrUrl(),
>  iface->name()));
> 
Looks like you forgot adding a "return;" here, and the same for the next path. 
Else I have no idea how this will prevent a crash. :-)

Greetings, David
[prev in list] [next in list] [prev in thread] [next in thread]