[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.3/kdemultimedia/kmix
From:       Colin Guthrie <kde () colin ! guthr ! ie>
Date:       2009-11-11 22:27:04
Message-ID: 1257978424.558286.3465.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1047729 by cguthrie:

kmix(pulse): Fix double unref of context

This is a simple fix to prevent an assert. The general method of
reallocating a single static context is in itself invalid and will
be addressed in future commits, but it wont crop up with the current
code structure.
CCBUG: 194178

 M  +10 -2     mixer_pulse.cpp  


--- branches/KDE/4.3/kdemultimedia/kmix/mixer_pulse.cpp #1047728:1047729
@@ -85,8 +85,16 @@
 
 int Mixer_PULSE::close()
 {
-    pa_context_unref(context);
-    pa_glib_mainloop_free(mainloop);
+    if (context)
+    {
+        pa_context_unref(context);
+        context = NULL;
+    }
+    if (mainloop)
+    {
+        pa_glib_mainloop_free(mainloop);
+        mainloop = NULL;
+    }
     return 1;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]