[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeutils/ark
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2009-11-04 3:18:58
Message-ID: 1257304738.746060.23649.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1044562 by rkcosta:

Use a const QString& in the parameter.

 M  +1 -1      kerfuffle/cliinterface.h  
 M  +1 -1      plugins/cli7zplugin/cliplugin.cpp  
 M  +1 -1      plugins/cli7zplugin/cliplugin.h  
 M  +1 -1      plugins/clirarplugin/cliplugin.cpp  
 M  +1 -1      plugins/clirarplugin/cliplugin.h  
 M  +1 -1      plugins/clizipplugin/cliplugin.cpp  


--- trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.h #1044561:1044562
@@ -228,7 +228,7 @@
     virtual bool deleteFiles(const QList<QVariant> & files);
 
     virtual ParameterList parameterList() const = 0;
-    virtual bool readListLine(QString line) = 0;
+    virtual bool readListLine(const QString &line) = 0;
 
 private:
     bool findProgramAndCreateProcess(const QString& program);
--- trunk/KDE/kdeutils/ark/plugins/cli7zplugin/cliplugin.cpp #1044561:1044562
@@ -73,7 +73,7 @@
     return p;
 }
 
-bool CliPlugin::readListLine(QString line)
+bool CliPlugin::readListLine(const QString &line)
 {
     switch (m_state) {
     case 0: // header
--- trunk/KDE/kdeutils/ark/plugins/cli7zplugin/cliplugin.h #1044561:1044562
@@ -36,7 +36,7 @@
 
 protected:
     virtual Kerfuffle::ParameterList parameterList() const;
-    virtual bool readListLine(QString line);
+    virtual bool readListLine(const QString &line);
 
 private:
     Kerfuffle::ArchiveEntry m_currentArchiveEntry;
--- trunk/KDE/kdeutils/ark/plugins/clirarplugin/cliplugin.cpp #1044561:1044562
@@ -78,7 +78,7 @@
     return p;
 }
 
-bool CliPlugin::readListLine(QString line)
+bool CliPlugin::readListLine(const QString &line)
 {
     const QString m_headerString = "-----------------------------------------";
 
--- trunk/KDE/kdeutils/ark/plugins/clirarplugin/cliplugin.h #1044561:1044562
@@ -36,7 +36,7 @@
 
     virtual Kerfuffle::ParameterList parameterList() const;
 
-    virtual bool readListLine(QString line);
+    virtual bool readListLine(const QString &line);
 
 protected:
     QString m_entryFilename;
--- trunk/KDE/kdeutils/ark/plugins/clizipplugin/cliplugin.cpp #1044561:1044562
@@ -88,7 +88,7 @@
 
     ReadStatus m_status;
 
-    bool readListLine(QString line) {
+    bool readListLine(const QString &line) {
         static QRegExp entryPattern(
             "^(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(.+)$");
  


[prev in list] [next in list] [prev in thread] [next in thread]