[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: koffice/kword/part
From: Inge Wallin <inge () lysator ! liu ! se>
Date: 2009-10-31 23:09:18
Message-ID: 200911010009.18644.inge () lysator ! liu ! se
[Download RAW message or body]
On Friday 30 October 2009 10:25:51 Thomas Zander wrote:
> On Wednesday 28. October 2009 10.42.39 Thomas Zander wrote:
> > On Wednesday 28. October 2009 10.28.40 Inge Wallin wrote:
> > > On Wednesday 28 October 2009 01:50:59 Inge Wallin wrote:
> > > > SVN commit 1041440 by ingwa:
> > > >
> > > > Implement padding for pages in KWord.
> > > >
> > > > This patch makes the page layout look the same in KWord and OO
> > > > writer, at least for simple cases.
>
> []
>
> > I reviewed the patch and I'd support backporting.
> > Can you do that?
>
> I take that back, there is a unit test that fails since you committed this.
> Looks like memory corruption as valgrind goes wild on that unit test.
> Please fix that before backporting.
It turns out that this has nothing to do with my patches. There are tests
that pass or fail randomly.
I ran the tests before and after the patch that renames top to topMargin, etc,
in KoPageLayout. And you were right, it did fail. But the test in question
that failed was test 58: libs-komain-KoProgressUpdaterTest, and I could see no
connection. So I ran the tests 10 times and here is the output of the summary
lines:
run1-1.out:94% tests passed, 7 tests failed out of 115
run1-2.out:94% tests passed, 7 tests failed out of 115
run1-3.out:94% tests passed, 7 tests failed out of 115
run1-4.out:93% tests passed, 8 tests failed out of 115
run1-5.out:93% tests passed, 8 tests failed out of 115
run1-6.out:94% tests passed, 7 tests failed out of 115
run1-7.out:94% tests passed, 7 tests failed out of 115
run1-8.out:94% tests passed, 7 tests failed out of 115
run1-9.out:94% tests passed, 7 tests failed out of 115
In run 4 it was test 8: libs-koaction-threadAction-TestAction that suddenly
failed and in run 5 it was the same.
When I applied the patch which adds padding, i.e. the one I think we should
backport, this was the result:
run2-1.out:94% tests passed, 7 tests failed out of 115
run2-2.out:93% tests passed, 8 tests failed out of 115
run2-3.out:94% tests passed, 7 tests failed out of 115
run2-4.out:93% tests passed, 8 tests failed out of 115
run2-5.out:94% tests passed, 7 tests failed out of 115
run2-6.out:94% tests passed, 7 tests failed out of 115
run2-7.out:94% tests passed, 7 tests failed out of 115
run2-8.out:94% tests passed, 7 tests failed out of 115
run2-9.out:94% tests passed, 7 tests failed out of 115
In run 2 it was again libs-komain-KoProgressUpdaterTest that failed and in run
4 the same.
Can somebody do the same experiment and see if you get a similar result?
Perhaps 10 runs is not enough, but my tests indicate that these 2 tests fail
in 10-20% of the runs. No idea why, but probably timing.
-Inge
PS
Interestingly enough, one of the runs produced a crash. The output from that
is attached.
["test-crash.out" (text/x-patch)]
*** glibc detected *** test 5
*** glibc detected *** \
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction: \
corrupted double-linked list: 0xb5f007c0 *** ======= Backtrace: ========= \
/lib/libc.so.6[0x99c3a4]
/lib/libc.so.6[0x99e123]
/lib/libc.so.6(cfree+0x96)[0x99e356]
/usr/lib/libstdc++.so.6(_ZdlPv+0x21)[0x2a7591]
/usr/lib/libQtCore.so.4(_ZN6QMutexD1Ev+0x30)[0x73c0060]
/local/KDE/src/branches/koffice/2.1/koffice-build/lib/./libkoaction.so.6[0x85066d] \
/local/KDE/src/branches/koffice/2.1/koffice-build/lib/./libkoaction.so.6[0x84f0d8] \
/local/KDE/src/branches/koffice/2.1/koffice-build/lib/./libkoaction.so.6(_ZN8KoActionD1Ev+0x38)[0x84ef14] \
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction[0x8049722] \
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction[0x8049ab9] \
/usr/lib/libQtCore.so.4(_ZNK11QMetaMethod6invokeEP7QObjectN2Qt14ConnectionTypeE22QGenericReturnArgument16QGenericArgumentS5_S5_S5_S5_S5_S5_S5_S5_S5_+0x4c9)[0x74c2ca9] \
/usr/lib/libQtCore.so.4(_ZN11QMetaObject12invokeMethodEP7QObjectPKcN2Qt14ConnectionTyp \
eE22QGenericReturnArgument16QGenericArgumentS7_S7_S7_S7_S7_S7_S7_S7_S7_+0x48f)[0x74c342f] \
/usr/lib/libQtTest.so.4[0x57d827] \
/usr/lib/libQtTest.so.4[0x57e68c] \
/usr/lib/libQtTest.so.4(_ZN5QTest5qExecEP7QObjectiPPc+0x383)[0x57ea23]
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction[0x8049c7a] \
/lib/libc.so.6(__libc_start_main+0xe5)[0x9436e5]
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction[0x80492e1] \
======= Memory map: ========
00110000-00111000 r-xp 00110000 00:00 0 [vdso]
00111000-00153000 r-xp 00000000 fd:00 479600 /usr/lib/libQtXml.so.4.5.2
00153000-00155000 rw-p 00041000 fd:00 479600 /usr/lib/libQtXml.so.4.5.2
00155000-00183000 r-xp 00000000 fd:00 489614 /usr/lib/libgssapi_krb5.so.2.2
00183000-00184000 rw-p 0002e000 fd:00 489614 /usr/lib/libgssapi_krb5.so.2.2
00184000-00186000 r-xp 00000000 fd:00 1343659 /lib/libcom_err.so.2.1
00186000-00187000 rw-p 00001000 fd:00 1343659 /lib/libcom_err.so.2.1
00187000-00190000 r-xp 00000000 fd:00 1933314 /usr/lib/libkrb5support.so.0.1
00190000-00191000 rw-p 00008000 fd:00 1933314 /usr/lib/libkrb5support.so.0.1
001ee000-002d5000 r-xp 00000000 fd:00 1934177 /usr/lib/libstdc++.so.6.0.10
002d5000-002d9000 r--p 000e6000 fd:00 1934177 /usr/lib/libstdc++.so.6.0.10
002d9000-002db000 rw-p 000ea000 fd:00 1934177 /usr/lib/libstdc++.so.6.0.10
002db000-002e0000 rw-p 002db000 00:00 0
002e2000-002e6000 r-xp 00000000 fd:00 1934337 /lib/libcap.so.2.10
002e6000-002e7000 rw-p 00003000 fd:00 1934337 /lib/libcap.so.2.10
002e9000-00328000 r-xp 00000000 fd:00 1933379 /lib/libdbus-1.so.3.4.0
00328000-00329000 r--p 0003e000 fd:00 1933379 /lib/libdbus-1.so.3.4.0
00329000-0032a000 rw-p 0003f000 fd:00 1933379 /lib/libdbus-1.so.3.4.0
0032c000-0033f000 r-xp 00000000 fd:00 1934181 /lib/libresolv-2.9.so
0033f000-00340000 r--p 00012000 fd:00 1934181 /lib/libresolv-2.9.so
00340000-00341000 rw-p 00013000 fd:00 1934181 /lib/libresolv-2.9.so
00341000-00343000 rw-p 00341000 00:00 0
00343000-0047a000 r-xp 00000000 fd:00 1353779 /lib/libcrypto.so.0.9.8g
0047a000-0048e000 rw-p 00136000 fd:00 1353779 /lib/libcrypto.so.0.9.8g
0048e000-00491000 rw-p 0048e000 00:00 0
00491000-0052d000 r-xp 00000000 fd:00 474140 /usr/lib/libkrb5.so.3.3
0052d000-00530000 rw-p 0009b000 fd:00 474140 /usr/lib/libkrb5.so.3.3
00577000-00591000 r-xp 00000000 fd:00 1933917 /usr/lib/libQtTest.so.4.5.2
00591000-00592000 rw-p 00019000 fd:00 1933917 /usr/lib/libQtTest.so.4.5.2
00592000-00593000 rw-p 00592000 00:00 0
005d6000-005d8000 r-xp 00000000 fd:00 1934225 /lib/libkeyutils-1.2.so
005d8000-005d9000 rw-p 00001000 fd:00 1934225 /lib/libkeyutils-1.2.so
005db000-005ff000 r-xp 00000000 fd:00 1933526 /usr/lib/libk5crypto.so.3.1
005ff000-00600000 rw-p 00024000 fd:00 1933526 /usr/lib/libk5crypto.so.3.1
006aa000-006ac000 r-xp 00000000 fd:00 819990 /usr/lib/gconv/UTF-16.so
006ac000-006ad000 r--p 00002000 fd:00 819990 /usr/lib/gconv/UTF-16.so
006ad000-006ae000 rw-p 00003000 fd:00 819990 /usr/lib/gconv/UTF-16.so
00822000-00832000 r-xp 00000000 fd:00 1934339 /lib/libbz2.so.1.0.4
00832000-00833000 rw-p 00010000 fd:00 1934339 /lib/libbz2.so.1.0.4
0084c000-00852000 r-xp 00000000 fd:01 6198700 \
/local/KDE/src/branches/koffice/2.1/koffice-build/lib/libkoaction.so.6.0.0 \
00852000-00853000 rw-p 00005000 fd:01 6198700 \
/local/KDE/src/branches/koffice/2.1/koffice-build/lib/libkoaction.so.6.0.0 \
0087b000-0089d000 r-xp 00000000 fd:00 461187 /usr/lib/liblzma.so.0.0.0
0089d000-0089e000 rw-p 00021000 fd:00 461187 /usr/lib/liblzma.so.0.0.0
00904000-00924000 r-xp 00000000 fd:00 2396219 /lib/ld-2.9.so
00925000-00926000 r--p 00020000 fd:00 2396219 /lib/ld-2.9.so
00926000-00927000 rw-p 00021000 fd:00 2396219 /lib/ld-2.9.so
0092d000-00a9b000 r-xp 00000000 fd:00 2396220 /lib/libc-2.9.so
00a9b000-00a9d000 r--p 0016e000 fd:00 2396220 /lib/libc-2.9.so
00a9d000-00a9e000 rw-p 00170000 fd:00 2396220 /lib/libc-2.9.so
00a9e000-00aa1000 rw-p 00a9e000 00:00 0
00aa3000-00aca000 r-xp 00000000 fd:00 1934071 /lib/libm-2.9.so
00aca000-00acb000 r--p 00026000 fd:00 1934071 /lib/libm-2.9.so
00acb000-00acc000 rw-p 00027000 fd:00 1934071 /lib/libm-2.9.so
00ace000-00ad1000 r-xp 00000000 fd:00 1934001 /lib/libdl-2.9.so
00ad1000-00ad2000 r--p 00002000 fd:00 1934001 /lib/libdl-2.9.so
00ad2000-00ad3000 rw-p 00003000 fd:00 1934001 /lib/libdl-2.9.so
00ad5000-00aeb000 r-xp 00000000 fd:00 1934173 /lib/libpthread-2.9.so
00aeb000-00aec000 r--p 00015000 fd:00 1934173 /lib/libpthread-2.9.so
00aec000-00aed000 rw-p 00016000 fd:00 1934173 /lib/libpthread-2.9.so
00aed000-00aef000 rw-p 00aed000 00:00 0
00af1000-00b04000 r-xp 00000000 fd:00 1934063 /lib/libz.so.1.2.3
00b04000-00b05000 rw-p 00012000 fd:00 1934063 /lib/libz.so.1.2.3
00c4b000-00c4f000 r-xp 00000000 fd:00 1350363 /lib/libgthread-2.0.so.0.1800.4 \
00c4f000-00c50000 rw-p 00003000 fd:00 1350363 /lib/libgthread-2.0.so.0.1800.4 \
00c58000-00cc4000 r-xp 00000000 fd:00 490496 /usr/lib/libQtDBus.so.4.5.2
00cc4000-00cc6000 rw-p 0006c000 fd:00 490496 /usr/lib/libQtDBus.so.4.5.2
00d4e000-00d56000 r-xp 00000000 fd:00 1934267 /lib/librt-2.9.so
00d56000-00d57000 r--p 00007000 fd:00 1934267 /lib/librt-2.9.so
00d57000-00d58000 rw-p 00008000 fd:00 1934267 /lib/librt-2.9.so
00ddf000-00dec000 r-xp 00000000 fd:00 1934175 /lib/libgcc_s-4.3.2-20081105.so.1 \
00dec000-00ded000 rw-p 0000c000 fd:00 1934175 /lib/libgcc_s-4.3.2-20081105.so.1 \
021a8000-0240d000 r-xp 00000000 fd:00 461842 /usr/lib/libkdecore.so.5.3.0
0240d000-02418000 rw-p 00264000 fd:00 461842 /usr/lib/libkdecore.so.5.3.0
027c9000-027dd000 r-xp 00000000 fd:00 481486 /usr/lib/libthreadweaver.so.4.3.0 \
027dd000-027de000 rw-p 00014000 fd:00 481486 /usr/lib/libthreadweaver.so.4.3.0 \
04e7b000-04ec2000 r-xp 00000000 fd:00 1933319 /lib/libssl.so.0.9.8g
04ec2000-04ec6000 rw-p 00046000 fd:00 1933319 /lib/libssl.so.0.9.8g
0712e000-07210000 r-xp 00000000 fd:00 1345046 /lib/libglib-2.0.so.0.1800.4
07210000-07211000 rw-p 000e2000 fd:00 1345046 /lib/libglib-2.0.so.0.1800.4
0735a000-07375000 r-xp 00000000 fd:00 1344473 /lib/libselinux.so.1
07375000-07376000 r--p 0001a000 fd:00 1344473 /lib/libselinux.so.1
07376000-07377000 rw-p 0001b000 fd:00 1344473 /lib/libselinux.so.1
07379000-075ac000 r-xp 00000000 fd:00 476053 /usr/lib/libQtCore.so.4.5.2
075ac000-075b2000 rw-p 00232000 fd:00 476053 /usr/lib/libQtCore.so.4.5.2
075b2000-075b3000 rw-p 075b2000 00:00 0
075b5000-076c5000 r-xp 00000000 fd:00 490112 /usr/lib/libQtNetwork.so.4.5.2
076c5000-076c8000 rw-p 00110000 fd:00 490112 /usr/lib/libQtNetwork.so.4.5.2
08048000-0804b000 r-xp 00000000 fd:01 3145310 \
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction \
0804b000-0804c000 rw-p 00002000 fd:01 3145310 \
/local/KDE/src/branches/koffice/2.1/koffice-build/libs/koaction/tests/TestAction \
097c0000-09802000 rw-p 097c0000 00:00 0 [heap] b54ff000-b5500000 ---p \
b54ff000 00:00 0 b5500000-b5f00000 rw-p b5500000 00:00 0
b5f00000-b5f21000 rw-p b5f00000 00:00 0
b5f21000-b6000000 ---p b5f21000 00:00 0
b6099000-b609a000 ---p b6099000 00:00 0
b609a000-b6a9a000 rw-p b609a000 00:00 0
b6a9a000-b6a9b000 ---p b6a9a000 00:00 0
b6a9b000-b749b000 rw-p b6a9b000 00:00 0
b749b000-b749c000 ---p b749b000 00:00 0
b749c000-b7e9c000 rw-p b749c000 00:00 0
b7e9c000-b809c000 r--p 00000000 fd:00 462648 /usr/lib/locale/locale-archive
b809c000-b80a4000 rw-p b809c000 00:00 0
b80bf000-b80c0000 rw
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic