[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/akonadi-ports/kdepim
From:       Thomas McGuire <mcguire () kde ! org>
Date:       2009-10-31 22:47:39
Message-ID: 200910312347.45349.mcguire () kde ! org
[Download RAW message or body]


Hi Sebastian,

On Saturday 31 October 2009 18:10:16 Sebastian Sauer wrote:
> SVN commit 1043062 by sebsauer:
> 
> * use akonadi to send mails (e.g. invitations)
> * removed kmail dependency from korganizer
> * more later

I'm looking at komailclient.cpp, but I have trouble understanding what you are 
doing there.

Why are you fetching all items from the outbox? I don't see where they are 
used.

Why are you using three different methods for sending? First, you use a 
MailTransport::TransportJob, which is deprecated.

Then, you manually create an Item in the outbox. Manually creating an Item in 
the outbox will not work, since it lacks the Item attributes that control the 
receivers, transport type and the like. The mail dispatcher agent, which 
monitors the outbox, doesn't know what to do with the item.

Finally, you use MailTransport::MessageQueueJob, which is the correct thing to 
do. The MessageQueueJob will, behind the scenes, create an Item and store that 
in the outbox, including all required attributes. The mail dispatcher agent 
will then pick up that item from the outbox and actually send it.

So all in all, I'm thoroughly confused. Am I missing something here? Please 
enlighten me :)

Regards,
Thomas

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]