[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    icecream
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2009-10-24 14:53:32
Message-ID: 1256396012.923209.11208.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1039761 by ossi:

Revert r951280 by osterfeld: "also check for EAGAIN (needed on OS X)"

> As I didn't observe an actual problem here (was hunting some other
> issue), that commit was probably premature and should be reverted
> for now.

 M  +1 -1      client/local.cpp  
 M  +1 -1      daemon/main.cpp  
 M  +1 -1      daemon/serve.cpp  
 M  +2 -2      daemon/workit.cpp  


--- trunk/icecream/client/local.cpp #1039760:1039761
@@ -244,7 +244,7 @@
                 }
                 if (r == 0)
                     break;
-                if ( r < 0 && errno != EINTR && errno != EAGAIN )
+                if ( r < 0 && errno != EINTR)
                     break;
             }
             colorify_output(s_ccout);
--- trunk/icecream/daemon/main.cpp #1039760:1039761
@@ -1159,7 +1159,7 @@
         off_t off = 0;
         while ( len ) {
             ssize_t bytes = write( client->pipe_to_child, fcmsg->buffer + off, len );
-            if ( bytes < 0 && ( errno == EINTR || errno == EAGAIN ) )
+            if ( bytes < 0 && errno == EINTR )
                 continue;
 
             if ( bytes == -1 ) {
--- trunk/icecream/daemon/serve.cpp #1039760:1039761
@@ -214,7 +214,7 @@
                 ssize_t bytes = read(obj_fd, buffer, sizeof(buffer));
                 if ( bytes < 0 )
                 {
-                    if ( errno == EINTR || errno == EAGAIN )
+                    if ( errno == EINTR )
                         continue;
                     throw myexception( EXIT_DISTCC_FAILED );
                 }
--- trunk/icecream/daemon/workit.cpp #1039760:1039761
@@ -316,7 +316,7 @@
             off_t off = 0;
             while ( len ) {
                 ssize_t bytes = write( sock_in[1], fcmsg->buffer + off, len );
-                if ( bytes < 0 && ( errno == EINTR || errno == EAGAIN ) )
+                if ( bytes < 0 && errno == EINTR )
                     continue;
 
                 write(job_in_fd, fcmsg->buffer + off, bytes);
@@ -370,7 +370,7 @@
         {
             char resultByte;
             ssize_t n = ::read(main_sock[0], &resultByte, 1);
-            if (n == -1 && ( errno == EINTR || errno == EAGAIN ) )
+            if (n == -1 && errno == EINTR)
                 continue; // Ignore
 
             if (n == 1)
[prev in list] [next in list] [prev in thread] [next in thread]