[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdesupport/taglib
From:       Lukáš Lalinský <lalinsky () gmail ! com>
Date:       2009-10-24 12:01:41
Message-ID: 1256385701.525995.893.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1039704 by lalinsky:

Don't wrote the Vorbis framing bit to OggFLAC files

https://bugs.launchpad.net/maxosx/+bug/445970
http://www.hydrogenaudio.org/forums/index.php?showtopic=75263

CCMAIL:me@sbooth.org


 M  +1 -1      taglib/ogg/flac/oggflacfile.cpp  
 M  +3 -0      tests/CMakeLists.txt  
 M  +4 -1      tests/Makefile.am  
 AM            tests/data/empty_flac.oga  
 AM            tests/data/empty_vorbis.ogg  
 AM            tests/test_oggflac.cpp   [License: UNKNOWN]


--- trunk/kdesupport/taglib/taglib/ogg/flac/oggflacfile.cpp #1039703:1039704
@@ -93,7 +93,7 @@
 
 bool Ogg::FLAC::File::save()
 {
-  d->xiphCommentData = d->comment->render();
+  d->xiphCommentData = d->comment->render(false);
 
   // Create FLAC metadata-block:
 
--- trunk/kdesupport/taglib/tests/CMakeLists.txt #1039703:1039704
@@ -14,6 +14,8 @@
   ${CMAKE_CURRENT_SOURCE_DIR}/../taglib/trueaudio
   ${CMAKE_CURRENT_SOURCE_DIR}/../taglib/ogg
   ${CMAKE_CURRENT_SOURCE_DIR}/../taglib/ogg/vorbis
+  ${CMAKE_CURRENT_SOURCE_DIR}/../taglib/ogg/flac
+  ${CMAKE_CURRENT_SOURCE_DIR}/../taglib/flac
 )
 
 SET(test_runner_SRCS
@@ -33,6 +35,7 @@
   test_aiff.cpp
   test_riff.cpp
   test_ogg.cpp
+  test_oggflac.cpp
 )
 IF(WITH_MP4)
    SET(test_runner_SRCS ${test_runner_SRCS} test_mp4.cpp)
--- trunk/kdesupport/taglib/tests/Makefile.am #1039703:1039704
@@ -7,6 +7,8 @@
         -I$(top_srcdir)/taglib/mpeg/id3v2 \
         -I$(top_srcdir)/taglib/ogg \
         -I$(top_srcdir)/taglib/ogg/vorbis \
+        -I$(top_srcdir)/taglib/ogg/flac \
+        -I$(top_srcdir)/taglib/flac \
         -I$(top_srcdir)/taglib/riff \
         -I$(top_srcdir)/taglib/riff/aiff \
         -I$(top_srcdir)/taglib/mpeg/id3v2/frames
@@ -26,7 +28,8 @@
 	test_xiphcomment.cpp \
 	test_riff.cpp \
 	test_aiff.cpp \
-	test_ogg.cpp
+	test_ogg.cpp \
+	test_oggflac.cpp
 
 if build_tests
 TESTS = test_runner
** trunk/kdesupport/taglib/tests/data/empty_flac.oga #property svn:mime-type
   + application/octet-stream
** trunk/kdesupport/taglib/tests/data/empty_vorbis.ogg #property svn:mime-type
   + application/octet-stream
** trunk/kdesupport/taglib/tests/test_oggflac.cpp #property svn:eol-style
   + native
[prev in list] [next in list] [prev in thread] [next in thread]