[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: koffice/kspread
From: Ariya Hidayat <ariya () kde ! org>
Date: 2009-10-23 20:10:29
Message-ID: 1256328629.910641.2418.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 1039558 by ariya:
Minor speed-up in the iterations by using const reference.
M +1 -1 Cell.cpp
M +2 -2 Functions.cpp
--- trunk/koffice/kspread/Cell.cpp #1039557:1039558
@@ -1352,7 +1352,7 @@
// each spreadsheet application likes to safe formulas with a different namespace
// prefix, so remove all of them
QStringList prefixes = QStringList() << "oooc:" << "kspr:" << "of:" << "msoxl:";
- foreach (QString prefix, prefixes) {
+ foreach (const QString &prefix, prefixes) {
if (oasisFormula.startsWith( prefix )) {
oasisFormula = oasisFormula.mid( prefix.length() );
break;
--- trunk/koffice/kspread/Functions.cpp #1039557:1039558
@@ -252,12 +252,12 @@
}
d->groups.removeAll(groupName);
QStringList functionNames;
- foreach (FunctionDescription* description, d->descriptions) {
+ foreach (const FunctionDescription* description, d->descriptions) {
if (description->group() == groupName) {
functionNames.append(description->name());
}
}
- foreach (QString functionName, functionNames) {
+ foreach (const QString &functionName, functionNames) {
d->functions.remove(functionName);
d->descriptions.remove(functionName);
}
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic