[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/runtime/kstyles/oxygen
From:       Matthew Woehlke <mwoehlke () tibco ! com>
Date:       2009-10-23 20:04:45
Message-ID: 4AE20C5D.2060400 () tibco ! com
[Download RAW message or body]

I meant to say this in reply to 1037632 also, but... you do realize that 
this makes the arrows potentially illegible on hover?

I think we would do better to have some sort of glow effect *around* the 
arrow rather than changing the arrow to an arbitrary color. (And yes, 
QPalette::Highlight is arbitrary, it is NOT the hover color, and 
moreover it is a background role, which is never, ever supposed to be 
used for foreground elements.)

Maybe HighlightText isn't perfect, but IMO Highlight is worse.

(It's especially bad for inactive windows, since inactive Highlight, 
i.e. KCS(Inactive, SelectionSet, NormalBackground) is by definition 
similar to KCS(Inactive, WindowSet, NormalBackground).)

If we stick with strictly text roles (i.e. no glow around the arrow), 
KCS(state, set, ActiveText) is actually the most appropriate color to use.

Matthew

On 2009-10-22 21:32, Hugo Pereira Da Costa wrote:
> SVN commit 1039218 by hpereiradacosta:
>
> disabled scrollbar arrows glow when scrollbar is disabled
>
>   M  +2 -2      oxygen.cpp
>
>
> --- trunk/KDE/kdebase/runtime/kstyles/oxygen/oxygen.cpp #1039217:1039218
> @@ -2254,7 +2254,7 @@
>           }
>
>           // handle scrollbar arrow hover
> -        if(const QScrollBar* scrollbar = qobject_cast<const QScrollBar*>(widget) )
> +        if( const QScrollBar* scrollbar = qobject_cast<const QScrollBar*>(widget) )
>           {
>               bool hover( false );
>
> @@ -2284,7 +2284,7 @@
>               }
>
>               // if all is good change arrow color
> -            if( hover ) { arrowColor = pal.color( QPalette::Highlight ); }
> +            if( hover&&  enabled ) { arrowColor = pal.color( QPalette::Highlight ); }
>
>           }
>
[prev in list] [next in list] [prev in thread] [next in thread]