[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kspread
From:       Ariya Hidayat <ariya () kde ! org>
Date:       2009-10-23 19:52:26
Message-ID: 1256327546.110467.27973.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1039552 by ariya:

Use QChar instead of QString for single-character strings.

 M  +1 -1      Cell.cpp  
 M  +1 -1      DependencyManager.cpp  
 M  +1 -1      Formula.cpp  
 M  +1 -1      GenValidationStyle.cpp  


--- trunk/koffice/kspread/Cell.cpp #1039551:1039552
@@ -1068,7 +1068,7 @@
     {
         //<office:annotation draw:style-name="gr1" draw:text-style-name="P1" \
svg:width="2.899cm" svg:height="2.691cm" svg:x="2.858cm" svg:y="0.001cm" \
draw:caption-point-x="-2.858cm" draw:caption-point-y="-0.001cm">  \
                xmlwriter.startElement( "office:annotation" );
-        const QStringList text = comment.split( "\n", QString::SkipEmptyParts );
+        const QStringList text = comment.split( '\n', QString::SkipEmptyParts );
         for ( QStringList::ConstIterator it = text.begin(); it != text.end(); ++it ) \
{  xmlwriter.startElement( "text:p" );
             xmlwriter.addTextNode( *it );
--- trunk/koffice/kspread/DependencyManager.cpp #1039551:1039552
@@ -246,7 +246,7 @@
     if (!tokens.valid())
         return;
 
-    QString expression = "=";
+    QString expression( '=' );
     Sheet* sheet = cell.sheet();
     for( int i = 0; i < tokens.count(); ++i )
     {
--- trunk/koffice/kspread/Formula.cpp #1039551:1039552
@@ -787,7 +787,7 @@
                  // for compatibility with oocalc (and the openformula spec), don't \
                parse single-quoted
                  // text as an identifier, instead add an Unknown token and remember \
we had an error  parseError = true;
-                 tokens.append( Token( Token::Unknown, "'" + tokenText + "'", \
tokenStart ) ); +                 tokens.append( Token( Token::Unknown, '\'' + \
tokenText + '\'', tokenStart ) );  }
              tokenStart = i;
              tokenText.clear();
--- trunk/koffice/kspread/GenValidationStyle.cpp #1039551:1039552
@@ -80,7 +80,7 @@
             writer.addAttribute( "table:title", it.key().title );
             writer.addAttribute( "table:display", \
it.key().displayValidationInformation );  
-            QStringList text = it.key().messageInfo.split( "\n", \
QString::SkipEmptyParts ); +            QStringList text = \
                it.key().messageInfo.split( '\n', QString::SkipEmptyParts );
             for ( QStringList::Iterator it2 = text.begin(); it2 != text.end(); ++it2 \
) {  writer.startElement( "text:p" );
                 writer.addTextNode( *it2 );


[prev in list] [next in list] [prev in thread] [next in thread]