[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/filters/kpresenter/powerpoint
From:       Jos van den Oever <jos () vandenoever ! info>
Date:       2009-10-16 7:43:22
Message-ID: 1255679002.625328.6676.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1035898 by vandenoever:

Improve ppt file importing

This is a patch by Vesa Pikki to improve ppt file importing. It is a big improvement \
that fixes many issues. Because it is rather big, I'm putting it on review board. \
This patch does not make text parsing perfect, more work is needed. In the future the \
patches will be smaller and more frequent.

Here is what he says about the patch:

Hi

Here is my patch for powerpoint filters. I must apologize that the patch is so big. I \
started initially working on supporting just the indentation, but soon realized the \
filter needs to support a lot of other data structures from powerpoint files to \
accomplish that. I tried to write it as general as possible and tried to support some \
more style data while I'm at it. I added support and/or implemented for these data \
                structures:
- MainMasterStyleAtom and it's levels which define master style for the powerpoint,
- TextCFRun and TextCFEception which define character level style for text
- TextPFRun and TextPFException which define paragraph level style for text
- ColorIndexStruct and ColorStruct which define (text) colors
- ColorSchemeAtom that defines color schemes
- FontEntityAtom which contains font definitions

Currently supported text styles are: bold, italic, left-margin, text-indent, \
text-align, font color, font size and font Currently supported bullet styles: \
bullet-char, space-after, font-family, bullet color, space-before Unfortunately there \
still exists couple problems with applying correct style to correct portion of text \
so I can't say they all work properly.

The thing that works is text indentation.

There are couple main things missing that mess up the styles:
-Some text data is not read properly and as styles are applied by character count \
basis any missing text results to a situation where rest of the text is being applied \
the wrong color.

-Text styles are defined as exceptions to main style. When applying a text style to \
text we'll first check if there is an exception to main style or just use the main \
style. Current code within this patch doesn't use the right main style. Then there's \
also a default style in DocumentTextInfoContainer that is ignored that might also be \
used when style is not found in text style exception. I must admit I'm not sure which \
style to use in each situation. It'll be something I will look into next.

-Escher text style (msofbtClientTextBox) is ignored.

 M  +632 -82   import/powerpointimport.cc  
 M  +170 -1    import/powerpointimport.h  
 M  +110 -215  libppt/objects.cpp  
 M  +57 -107   libppt/objects.h  
 M  +2225 -471 libppt/powerpoint.cpp  
 M  +841 -188  libppt/powerpoint.h  
 M  +17 -1     libppt/presentation.cpp  
 M  +16 -1     libppt/presentation.h  
 M  +10 -4     libppt/slide.cpp  
 M  +3 -3      libppt/slide.h  


http://websvn.kde.org/?view=rev&revision=1035898


[prev in list] [next in list] [prev in thread] [next in thread]