[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/akonadi-ports
From:       Frank Osterfeld <frank.osterfeld () gmx ! de>
Date:       2009-10-15 20:35:22
Message-ID: 200910152235.22436.frank.osterfeld () gmx ! de
[Download RAW message or body]

On Thursday 15 October 2009 07:34:34 pm Sebastian Sauer wrote:

> @@ -213,10 +212,10 @@
>    lst << QString( "AlarmDeamon::dumpAlarms() from " ) + start.toString() +
>  " to " + end.toString();
> 
> -  QList<Alarm *> alarms = mCalendar->alarms( start, end );
> -  QList<Alarm *>::ConstIterator it;
> -  for ( it = alarms.constBegin(); it != alarms.constEnd(); ++it ) {
> -    Alarm *a = *it;
> +  Akonadi::Item::List alarms = mCalendar->alarms( start, end );
> +  foreach(const Akonadi::Item &alarm, alarms) {
> +    Q_ASSERT(alarm.hasPayload<Alarm::Ptr>());
> +    Alarm::Ptr a = alarm.payload<Alarm::Ptr>();

I'd suggest to add Alarm::Ptr Akonadi::alarm() and bool Akonadi::hasAlarm() to 
kdepim/akonadi/kcal/utils.h, to avoid asserts/ifs hasPayload<Alarm::Ptr>... 
payload<Alarm::Ptr>(), like we have for the other types there.

Frank


[prev in list] [next in list] [prev in thread] [next in thread]