[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/kontact/plugins/summary
From:       Allen Winter <winter () kde ! org>
Date:       2009-10-03 12:31:49
Message-ID: 1254573109.750052.28737.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1030887 by winterz:

Show kcm pages for all the summary plugins, not just the active summary plugins.
I think this is less confusing.

The old way went like this: select a summary plugin to be active -> apply/ok -> then configure
Now you can configure and select a summary plugin and then apply/ok

MERGE: none
DO_NOT_BACKPORT:


 M  +6 -4      summaryview_part.cpp  


--- trunk/KDE/kdepim/kontact/plugins/summary/summaryview_part.cpp #1030886:1030887
@@ -21,7 +21,6 @@
   the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
    Boston, MA 02110-1301, USA.
 */
-
 #include "summaryview_part.h"
 
 #include <kontactinterface/summary.h>
@@ -157,9 +156,12 @@
   QList<KontactInterface::Plugin*>::ConstIterator it = plugins.constBegin();
   for ( ; it != end; ++it ) {
     KontactInterface::Plugin *plugin = *it;
-    if ( !activeSummaries.contains( plugin->identifier() ) ) {
-      continue;
-    }
+    //winterz: comment out the next block because I think showing the
+    //configuration page for all summaries, even if they aren't active,
+    //is less confusing for the user.
+    //if ( !activeSummaries.contains( plugin->identifier() ) ) {
+    //  continue;
+    //}
 
     KontactInterface::Summary *summary = plugin->createSummaryWidget( mFrame );
     if ( summary ) {
[prev in list] [next in list] [prev in thread] [next in thread]