[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/kcontrol/kfontinst
From:       David Faure <faure () kde ! org>
Date:       2009-10-02 20:46:33
Message-ID: 200910022246.33924.faure () kde ! org
[Download RAW message or body]

On Thursday 24 September 2009, Craig Drummond wrote:
> SVN commit 1027819 by craig:
> 
> Copy over re-worked fontinst from branches/work/kfontinst
> 
> Main changes:
> 
> * Create a dbus daemon for handling font installtion, and have the kcm
> and ioslave use this.
> A             dbus/org.kde.fontinst.service.cmake

Hi,

this change makes fonts:/System just hang for me.
It's blocks in QCoreApplication::exec (1), waiting for dbus signals from
"fontinst" which is not running. I see that you installed a \
org.kde.fontinst.service file for dbus, but this doesn't work when  install \
KDE into a custom prefix (which is the recommended way for development...)

Can you manually start the service when it's not already running?
It should be as simple as
   if (!QDBusConnection::sessionBus().interface()->isServiceRegistered("org.kde.fontinst")) \
{  // start it (via QProcess or KToolInvocation)
   }

(1) the on-demand QCoreApplication creation reads a bit strange, how about \
just doing that in the kioslave main? That's an okay thing to do, other \
slaves do it too. And then you can use QEventLoop exec() + quit() rather \
than QCoreApplication exec() + exit() (which reads funky because it doesn't \
actually exit the application). For an example, see \
kioslave/thumbnail/htmlcreator.cpp

./thumbnail/htmlcreator.cpp:68:    \
                m_eventLoop.exec(QEventLoop::ExcludeUserInputEvents);
./thumbnail/htmlcreator.h:26:#include <QEventLoop>
./thumbnail/htmlcreator.h:47:    QEventLoop m_eventLoop;
void HTMLCreator::slotCompleted()
{
    m_eventLoop.quit();
}

-- 
David Faure, faure@kde.org, sponsored by Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]