[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/plasma/widgets
From:       Jacopo De Simoi <wilderkde () gmail ! com>
Date:       2009-09-30 22:10:36
Message-ID: 1254348636.594097.28718.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1029853 by jacopods:

workaround some qt bug which makes children items disappear when toggling the ItemClipsChildrenToShape flag


 M  +11 -2     scrollwidget.cpp  


--- trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp #1029852:1029853
@@ -133,7 +133,7 @@
             rightBorder->deleteLater();
             leftBorder = 0;
             rightBorder = 0;
-        } 
+        }
 
         layout->activate();
 
@@ -170,7 +170,16 @@
         const bool clip = widget->size().width() > scrollingWidget->size().width() ||
                           widget->size().height() > scrollingWidget->size().height();
 
-        scrollingWidget->setFlag(QGraphicsItem::ItemClipsChildrenToShape, clip);
+        /* FIXME: it should really be like this:
+         *
+         * scrollingWidget->setFlag(QGraphicsItem::ItemClipsChildrenToShape, clip);
+         *
+         * however, a qt bug prevents this to work properly when toggling this flag,
+         * so we have to keep the children items always clipped (performance--)
+         * until the bug is fixed.
+         */
+
+        scrollingWidget->setFlag(QGraphicsItem::ItemClipsChildrenToShape, true);
     }
 
     ScrollWidget *q;
[prev in list] [next in list] [prev in thread] [next in thread]