[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevelop/projectmanagers/cmake/parser
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2009-09-30 21:42:48
Message-ID: 757d9a550909301442l76709ebx6f4dbdcaa36ca6fa () mail ! gmail ! com
[Download RAW message or body]

On Wed, Sep 30, 2009 at 11:28 PM, Andreas Pakulat <apaku@gmx.de> wrote:

> On 30.09.09 20:26:00, Aleix Pol Gonzalez wrote:
> > SVN commit 1029826 by apol:
> >
> > Fix last commit.
> > - Do not use QDir::separator, it's just wrong, Qt deals with it.
>
> Ah, sorry too much java done lately :)
>
:)


>
> > - Adapt to the current infrastructure.
>
> Thats the part about suffixes/pathSuffixes right? If so its wrong.
> pathSuffixes are appended to the current location. So if you have
>
> find_path( foo.h
>    PATH_SUFFIXES bar )
>
> CMake searches for
> <prefix>/include/foo.h
> <prefix>/include/bar/foo.h
>
> So you can't just add "include" to suffixes here. You really have to
> iterate over the XXX_PREFIX_PATH variables and for each one add
> <prefix>/include to the locationOptions.
>
That's what suffix does, maybe it's not the best naming, but that's what
suffix does.


>
> Also with this change you'd find a
>
> <Framework-path>/include/foo.h
>
> which CMake wouldn't find as it only searches for
>
> <Framework-path>/foo.h
>
> I've had a short look today at the CMake code that does all this and
> its a bit complicated to read because of many 'forwarding' calls of
> addXXX functions, but most of this is in cmFindCommon.cxx and
> cmFindBase.cxx. And the cmake manual also seems to be pretty complete
> about what paths are searched for.
>

It's in cmFindBase.cxx, cmFindBase::AddPrefixPaths.


>
> Andreas
>
> --
> You have a deep interest in all that is artistic.
>

[Attachment #3 (text/html)]

<br><br><div class="gmail_quote">On Wed, Sep 30, 2009 at 11:28 PM, Andreas Pakulat <span dir="ltr">&lt;<a \
href="mailto:apaku@gmx.de">apaku@gmx.de</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" \
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div \
class="im">On 30.09.09 20:26:00, Aleix Pol Gonzalez wrote:<br> &gt; SVN commit 1029826 by apol:<br>
&gt;<br>
&gt; Fix last commit.<br>
&gt; - Do not use QDir::separator, it&#39;s just wrong, Qt deals with it.<br>
<br>
</div>Ah, sorry too much java done lately :)<br></blockquote><div>:)<br>  <br></div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; \
padding-left: 1ex;"> <div class="im"><br>
&gt; - Adapt to the current infrastructure.<br>
<br>
</div>Thats the part about suffixes/pathSuffixes right? If so its wrong.<br>
pathSuffixes are appended to the current location. So if you have<br>
<br>
find_path( foo.h<br>
      PATH_SUFFIXES bar )<br>
<br>
CMake searches for<br>
&lt;prefix&gt;/include/foo.h<br>
&lt;prefix&gt;/include/bar/foo.h<br>
<br>
So you can&#39;t just add &quot;include&quot; to suffixes here. You really have to<br>
iterate over the XXX_PREFIX_PATH variables and for each one add<br>
&lt;prefix&gt;/include to the locationOptions.<br></blockquote><div>That&#39;s what suffix does, maybe \
it&#39;s not the best naming, but that&#39;s what suffix does.<br>  <br></div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; \
padding-left: 1ex;">

<br>
Also with this change you&#39;d find a<br>
<br>
&lt;Framework-path&gt;/include/foo.h<br>
<br>
which CMake wouldn&#39;t find as it only searches for<br>
<br>
&lt;Framework-path&gt;/foo.h<br>
<br>
I&#39;ve had a short look today at the CMake code that does all this and<br>
its a bit complicated to read because of many &#39;forwarding&#39; calls of<br>
addXXX functions, but most of this is in cmFindCommon.cxx and<br>
cmFindBase.cxx. And the cmake manual also seems to be pretty complete<br>
about what paths are searched for.<br></blockquote><div><br>It&#39;s in cmFindBase.cxx, \
cmFindBase::AddPrefixPaths.<br>  <br></div><blockquote class="gmail_quote" style="border-left: 1px solid \
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

<br>
Andreas<br>
<font color="#888888"><br>
--<br>
You have a deep interest in all that is artistic.<br>
</font></blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]