[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevelop/languages/cpp/parser
From:       Bertjan Broeksema <b.broeksema () home ! nl>
Date:       2009-09-28 15:52:30
Message-ID: 1254153150.201688.7306.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1028951 by bbroeksema:

Disable a debug statement that causes a crash because the DUChain is not locked.

A better fix might be to find out why it is not locked (assuming that it should
be locked at that point). However, I'm not shure if it should be guaranteed that
the DUChain is locked in mapAstDuChain.


 M  +4 -2      parsesession.cpp  


--- trunk/KDE/kdevelop/languages/cpp/parser/parsesession.cpp #1028950:1028951
@@ -66,8 +66,10 @@
   Q_ASSERT(m_AstToDuchain.find(node) == m_AstToDuchain.end() ||
            m_AstToDuchain[node] != declaration);
   
-  kDebug() << "Mapping AST node: " << names[node->kind] <<
-              "With Declaration: " << declaration->toString();
+  // NOTE: Don't call declaration->toString() here. It seems that you cannot
+  //        assume at this point that the DUChain is at least locked for reading.
+  //kDebug() << "Mapping AST node: " << names[node->kind] <<
+  //            "With Declaration: " << declaration->toString();
   
   m_AstToDuchain[node] = declaration;
   m_DuchainToAst[declaration] = node;
[prev in list] [next in list] [prev in thread] [next in thread]