[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/kdepim/enterprise4/kdepimlibs
From:       Thomas McGuire <mcguire () kde ! org>
Date:       2009-09-09 14:43:12
Message-ID: 1252507392.768786.13435.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1021575 by tmcguire:

Merged revisions 1015975,1016229 via svnmerge from 
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/KDE/4.3/kdepimlibs

........
  r1015975 | tnyblom | 2009-08-26 20:01:11 +0200 (Wed, 26 Aug 2009) | 6 lines
  
  Backport r1015973
  Generete error when emailaddress ends with a dot (.)
  
  CCBUG: 139477
........
  r1016229 | tnyblom | 2009-08-27 10:23:00 +0200 (Thu, 27 Aug 2009) | 6 lines
  
  Revert r1015973 pending a better solution.
  
  Keep the unittests but adopted to the old behaviour.
  
  CCBUG: 139477
........


 _M            . (directory)  
 M  +17 -0     kpimutils/tests/testemail.cpp  


** branches/kdepim/enterprise4/kdepimlibs #property svnmerge-integrated
   - /branches/KDE/4.3/kdepimlibs:1-986158,990023,990532,990575,990631,990684,991932,9 \
96755,997101,997490,998251,1000615,1007460,1008037,1008812,1009437,1011841,1013328-1013331,1013810,1015198
  + /branches/KDE/4.3/kdepimlibs:1-986158,990023,990532,990575,990631,990684,991932,99 \
6755,997101,997490,998251,1000615,1007460,1008037,1008812,1009437,1011841,1013328-1013331,1013810,1015198,1015975-1016224,1016226-1016229
                
--- branches/kdepim/enterprise4/kdepimlibs/kpimutils/tests/testemail.cpp \
#1021574:1021575 @@ -120,6 +120,15 @@
   return true;
 }
 
+static bool checkIsValidAddressList( const QString &list, const QString \
&expErrorCode ) +{
+  QString badAddress;
+  EmailParseResult realErrorCode = isValidAddressList( list, badAddress );
+  QString errorCode = emailTestParseResultToString(  realErrorCode );
+  check( "isValidAddressList " + list + " errorCode ", errorCode, expErrorCode );
+  return true;
+}
+
 static bool checkIsValidSimpleEmailAddress( const QString &input, const QString \
&expResult )  {
   bool validEmail = isValidSimpleAddress( input );
@@ -407,6 +416,14 @@
 
   checkIsValidEmailAddress( "Matt Douhan <matt\"@@\"fruitsalad.org>", "TooFewAts" );
 
+  //bug  139477
+  checkIsValidAddressList( "martin.schulte@guug.de, msadmin@guug.de, \
msnewsletter@guug.de", "AddressOk" ); +  checkIsValidAddressList( \
"martin.schulte@guug.de; msadmin@guug.de; msnewsletter@guug.de", "AddressOk" ); +  \
checkIsValidAddressList( "martin.schulte@guug.de, msadmin@guug.de., \
msnewsletter@guug.de", "AddressOk" ); +  checkIsValidAddressList( "Martin Schulte \
<martin.schulte@guug.de>, MS Admin <msadmin@guug.de>, MS News \
<msnewsletter@guug.de>", "AddressOk" ); +  checkIsValidAddressList( "Martin Schulte \
<martin.schulte@guug.de>; MS Admin <msadmin@guug.de>; MS News \
<msnewsletter@guug.de>", "AddressOk" ); +  checkIsValidAddressList( "Martin Schulte \
<martin.schulte@guug.de.>, MS Admin <msadmin@guug.de>, MS News \
<msnewsletter@guug.de>", "AddressOk" ); +
   // checks for "pure" email addresses in the form of xxx@yyy.tld
   checkIsValidSimpleEmailAddress( "matt@fruitsalad.org", "true" );
   checkIsValidSimpleEmailAddress( QString::fromUtf8( "test@täst.invalid" ), "true" \
);


[prev in list] [next in list] [prev in thread] [next in thread]