[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/akregator/src
From:       Michael Jansen <kde () michael-jansen ! biz>
Date:       2009-09-06 20:33:28
Message-ID: 1252269208.607074.15677.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1020649 by mjansen:

Fix a memory leak.

I think what this method is supposed to do is not really good documented.
So inheriting from BrowserRun - which is allowed - is kind of guesswork.

Some assertions would probably help after calling it.

    - is the timer started for example?

Or redesigning it :(

CCMAIL:faure@kde.org

 M  +6 -1      browserrun.cpp  


--- trunk/KDE/kdepim/akregator/src/browserrun.cpp #1020648:1020649
@@ -48,11 +48,16 @@
 
     emit signalFoundMimeType( m_request );
 
-    if ( m_request.wasHandled() )
+    if ( m_request.wasHandled() ) {
+        setFinished(true);
+        timer().start();
         return;
+    }
 
     if ( handleNonEmbeddable(type) == KParts::BrowserRun::NotHandled )
         KRun::foundMimeType( type );
+
+
 }
 
 } // namespace Akregator
[prev in list] [next in list] [prev in thread] [next in thread]