[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: KDE/kdebase/workspace/libs/ksysguard/processcore
From: John Tapsell <john.tapsell () kdemail ! net>
Date: 2009-08-26 14:51:06
Message-ID: 1251298266.783832.24650.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 1015894 by johnflux:
Expand comment to explain why we used to add 3
M +5 -1 processes_linux_p.cpp
--- trunk/KDE/kdebase/workspace/libs/ksysguard/processcore/processes_linux_p.cpp \
#1015893:1015894 @@ -281,7 +281,11 @@
/* There was a "(ps->vmRss+3) * sysconf(_SC_PAGESIZE)" here in the original \
ksysguard code. I have no idea why! After comparing it to
* meminfo and other tools, this means we report the RSS by 12 bytes \
differently compared to them. So I'm removing the +3
- * to be consistent. NEXT TIME COMMENT STRANGE THINGS LIKE THAT! :-) */
+ * to be consistent. NEXT TIME COMMENT STRANGE THINGS LIKE THAT! :-)
+ *
+ * Update: I think I now know why - the kernel allocates 3 pages for
+ * tracking information about each the process. This memory isn't
+ * included in vmRSS..*/
ps->setVmRSS(vmRSS * sysconf(_SC_PAGESIZE) / 1024); /*convert to KiB*/
ps->setVmSize(vmSize /= 1024); /* convert to KiB */
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic