[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/plasma
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2009-08-20 9:34:39
Message-ID: 1250760879.321856.3934.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1013572 by aseigo:

don't do an immediate call if the data set is empty. this _shouldn't_ break anything \
(worst case is that a visualization would be expecting notification of an empty data \
set, and now it'll have to wait) and should line up with widget writer's expectations \
better (it's probably the #1 thing we get feedback on when it comes to dataengine \
usage)


 M  +2 -1      dataengine.cpp  


--- trunk/KDE/kdelibs/plasma/dataengine.cpp #1013571:1013572
@@ -603,7 +603,8 @@
         // we don't want to do an immediate call if we are simply
         // reconnecting
         //kDebug() << "immediate call requested, we have:" << \
                s->visualizationIsConnected(visualization);
-        immediateCall = !s->visualizationIsConnected(visualization);
+        immediateCall = !s->data().isEmpty() &&
+                        !s->visualizationIsConnected(visualization);
     }
 
     s->connectVisualization(visualization, pollingInterval, align);


[prev in list] [next in list] [prev in thread] [next in thread]