[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/akregator/src
From:       Michael Jansen <kde () michael-jansen ! biz>
Date:       2009-08-13 20:14:47
Message-ID: 1250194487.052173.4967.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1011040 by mjansen:

Fix memleak. Free the dummy factory if registerFactory returns false.

 M  +4 -1      akregator_part.cpp  


--- trunk/KDE/kdepim/akregator/src/akregator_part.cpp #1011039:1011040
@@ -184,7 +184,10 @@
     m_standardFeedList = KGlobal::dirs()->saveLocation("data", "akregator/data") + "/feeds.opml";
 
     Backend::StorageFactoryDummyImpl* dummyFactory = new Backend::StorageFactoryDummyImpl();
-    Backend::StorageFactoryRegistry::self()->registerFactory(dummyFactory, dummyFactory->key());
+    if (!Backend::StorageFactoryRegistry::self()->registerFactory(dummyFactory, dummyFactory->key())) {
+        // There was already a dummy factory registered.
+        delete dummyFactory;
+    }
     loadPlugins( QLatin1String("storage") ); // FIXME: also unload them!
 
     m_storage = 0;
[prev in list] [next in list] [prev in thread] [next in thread]