[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs
From:       Allen Winter <winter () kde ! org>
Date:       2009-08-11 19:46:23
Message-ID: 200908111546.23467.winter () kde ! org
[Download RAW message or body]

On Tuesday 11 August 2009 3:40:23 pm David Faure wrote:
> SVN commit 1010164 by dfaure:
> 
> libboost-graph-dev is required, say so from the start
> 
> 
> M  +2 -2      CMakeLists.txt  
> 
> 
> --- trunk/KDE/kdepimlibs/CMakeLists.txt #1010163:1010164
> @@ -30,8 +30,8 @@
> ############### Find the stuff we need ###############
> 
> set(Boost_MINIMUM_VERSION "1.33.1")
> -find_package(Boost)
> -macro_log_feature(Boost_FOUND "Boost" "Boost C++ Libraries" "http://www.boost.org" \
> TRUE "" "Required by several critical KDEPIM apps.") +find_package(Boost 1.33.1 \
> COMPONENTS graph) +macro_log_feature(Boost_FOUND "Boost" "Boost C++ Libraries" \
> "http://www.boost.org" TRUE "" "The boost libraries boost and boost-graph are \
> required by several critical KDEPIM apps.")


Would this work?
set(Boost_MINIMUM_VERSION "1.33.1")
find_package(Boost ${Boost_MINIMUM_VERSION} COMPONENTS graph)
macro_log_feature(Boost_FOUND "Boost" "Boost C++ Libraries" "http://www.boost.org" \
TRUE "${Boost_MINIMUM_VERSION}" "The boost libraries boost and boost-graph are \
required by several critical KDEPIM apps.")

mainly to set the minimum version once, and then use it in the macro_log_feature \
message.



> 
> #FindGpgme.cmake already handles the log message but we must ensure it is required.
> find_package(Gpgme REQUIRED)
> 

-- 
Allen Winter | allen@kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions


[prev in list] [next in list] [prev in thread] [next in thread]