[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeutils/okteta/libs/kasten/core/tests
From:       Friedrich W. H. Kossebau <kossebau () kde ! org>
Date:       2009-08-07 15:53:18
Message-ID: 1249660398.698991.22478.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1008475 by kossebau:

changed: renamed AbstractDocument signal modified() to syncStatesChanged(); \
DocumentManager signals now lists of added/closing documents

 M  +6 -6      documentmanagertest.cpp  
 M  +7 -3      testdocument.cpp  
 M  +2 -2      testdocumenttest.cpp  


--- trunk/KDE/kdeutils/okteta/libs/kasten/core/tests/documentmanagertest.cpp \
#1008474:1008475 @@ -31,14 +31,14 @@
 #include <QtTest/QSignalSpy>
 
 
-Q_DECLARE_METATYPE ( Kasten::AbstractDocument*  )
+Q_DECLARE_METATYPE ( QList<Kasten::AbstractDocument*>  )
 
 void DocumentManagerTest::checkAdded( QSignalSpy* changedSpy, \
Kasten::AbstractDocument* document )  {
    QVERIFY( changedSpy->isValid() );
    QCOMPARE( changedSpy->count(), 1 );
    QList<QVariant> arguments = changedSpy->takeFirst();
-   QCOMPARE( arguments.at(0).value<Kasten::AbstractDocument* >(), document );
+   QCOMPARE( arguments.at(0).value<QList<Kasten::AbstractDocument*> >().at(0), \
document );  }
 
 void DocumentManagerTest::checkRemoving( QSignalSpy* changedSpy, \
Kasten::AbstractDocument* document ) @@ -46,7 +46,7 @@
    QVERIFY( changedSpy->isValid() );
    QCOMPARE( changedSpy->count(), 1 );
    QList<QVariant> arguments = changedSpy->takeFirst();
-   QCOMPARE( arguments.at(0).value<Kasten::AbstractDocument* >(), document );
+   QCOMPARE( arguments.at(0).value<QList<Kasten::AbstractDocument*> >().at(0), \
document );  }
 
 
@@ -58,15 +58,15 @@
 
 void DocumentManagerTest::testAddRemove()
 {
-    qRegisterMetaType<Kasten::AbstractDocument* >("Kasten::AbstractDocument* ");
+    qRegisterMetaType<Kasten::AbstractDocument* \
>("QList<Kasten::AbstractDocument*>");  
     Kasten::TestDocument* doc1 = new Kasten::TestDocument();
     Kasten::TestDocument* doc2 = new Kasten::TestDocument();
     Kasten::TestDocument* doc3 = new Kasten::TestDocument();
 
     Kasten::DocumentManager* documentManager = new Kasten::DocumentManager();
-    QSignalSpy* addedSpy = new QSignalSpy( documentManager, SIGNAL(added( \
                Kasten::AbstractDocument*  )) );
-    QSignalSpy* closingSpy = new QSignalSpy( documentManager, SIGNAL(closing( \
Kasten::AbstractDocument*  )) ); +    QSignalSpy* addedSpy = new QSignalSpy( \
documentManager, SIGNAL(added( const QList<Kasten::AbstractDocument*>& )) ); +    \
QSignalSpy* closingSpy = new QSignalSpy( documentManager, SIGNAL(closing( const \
QList<Kasten::AbstractDocument*>& )) );  
     documentManager->addDocument( doc1 );
     checkAdded( addedSpy, doc1 );
--- trunk/KDE/kdeutils/okteta/libs/kasten/core/tests/testdocument.cpp \
#1008474:1008475 @@ -42,11 +42,15 @@
 QString TestDocument::title() const { return mTitle; }
 TestDocument::SynchronizationStates TestDocument::synchronizationStates() const { \
return mSynchronizationStates; }  const QByteArray* TestDocument::data() const { \
                return &mData; }
-void TestDocument::setData( const QByteArray &data )
+void TestDocument::setData( const QByteArray& data )
 {
+    const SynchronizationStates oldSyncStates = mSynchronizationStates;
+
     mData = data;
+
     mSynchronizationStates |= LocalHasChanges;
-    emit modified( mSynchronizationStates );
+    if( oldSyncStates != mSynchronizationStates )
+        emit syncStatesChanged( mSynchronizationStates );
 }
 
 void TestDocument::setTitle( const QString &title )
@@ -62,7 +66,7 @@
     if( mSynchronizationStates != synchronizationStates )
     {
         mSynchronizationStates = synchronizationStates;
-        emit modified( synchronizationStates );
+        emit syncStatesChanged( synchronizationStates );
     }
 }
 
--- trunk/KDE/kdeutils/okteta/libs/kasten/core/tests/testdocumenttest.cpp \
#1008474:1008475 @@ -84,7 +84,7 @@
 
     Kasten::TestDocument* document = new Kasten::TestDocument();
 
-    QSignalSpy* changedSpy = new QSignalSpy( document, SIGNAL(modified( \
Kasten::AbstractDocument::SynchronizationStates )) ); +    QSignalSpy* changedSpy = \
new QSignalSpy( document, SIGNAL(syncStatesChanged( \
Kasten::AbstractDocument::SynchronizationStates )) );  
     QCOMPARE( *document->data(), QByteArray() );
     QCOMPARE( document->synchronizationStates(), Kasten::TestDocument::InSync );
@@ -123,7 +123,7 @@
 
     Kasten::TestDocument* document = new Kasten::TestDocument();
 
-    QSignalSpy* changedSpy = new QSignalSpy( document, SIGNAL(modified( \
Kasten::AbstractDocument::SynchronizationStates )) ); +    QSignalSpy* changedSpy = \
new QSignalSpy( document, SIGNAL(syncStatesChanged( \
Kasten::AbstractDocument::SynchronizationStates )) );  
     const Kasten::AbstractDocument::SynchronizationStates
         states( Kasten::AbstractDocument::LocalHasChanges | \
Kasten::AbstractDocument::RemoteUnknown );


[prev in list] [next in list] [prev in thread] [next in thread]