[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/network/telepathy-accounts-kcm/src
From:       George Goldberg <grundleborg () googlemail ! com>
Date:       2009-08-03 13:17:52
Message-ID: 1249305472.572326.18123.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1006307 by gberg:

Stick with a loop and deletelater() since qDeleteAll calls only delete, and I don't \
think this is good practice with widgets with signal/slot connections all over the \
place.

 M  +5 -2      add-account-assistant.cpp  


--- trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.cpp \
#1006306:1006307 @@ -128,8 +128,11 @@
                 d->mandatoryParametersWidget = 0;
             }
 
-            // TODO: Check if this calls delete, or ->deleteLater() once I have \
                internet access again :)
-            qDeleteAll(d->optionalParametersWidgets);
+            foreach (AbstractAccountParametersWidget *w, \
d->optionalParametersWidgets) { +                if (w) {
+                    w->deleteLater();
+                }
+            }
             d->optionalParametersWidgets.clear();
 
             // Set up the Mandatory Parameters page


[prev in list] [next in list] [prev in thread] [next in thread]