[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kplato
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2009-08-02 15:46:27
Message-ID: 1249227987.667856.17891.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1005925 by aacid:

foreach already iterates over values so calling values explicitely is a waste both in \
memory and processing time


 M  +2 -2      libs/kernel/kptproject.cpp  
 M  +2 -2      libs/models/kptresourceappointmentsmodel.cpp  
 M  +6 -6      workpackage/part.cpp  


--- trunk/koffice/kplato/libs/kernel/kptproject.cpp #1005924:1005925
@@ -469,7 +469,7 @@
 DateTime Project::checkStartConstraints( const DateTime &dt ) const
 {
     DateTime t = dt;
-    foreach ( Node *n, nodeIdDict.values() ) {
+    foreach ( Node *n, nodeIdDict ) {
         if ( n->type() == Node::Type_Task || n->type() == Node::Type_Milestone ) {
             switch ( n->constraint() ) {
                 case Node::FixedInterval:
@@ -487,7 +487,7 @@
 DateTime Project::checkEndConstraints( const DateTime &dt ) const
 {
     DateTime t = dt;
-    foreach ( Node *n, nodeIdDict.values() ) {
+    foreach ( Node *n, nodeIdDict ) {
         if ( n->type() == Node::Type_Task || n->type() == Node::Type_Milestone ) {
             switch ( n->constraint() ) {
                 case Node::FixedInterval:
--- trunk/koffice/kplato/libs/models/kptresourceappointmentsmodel.cpp \
#1005924:1005925 @@ -1570,7 +1570,7 @@
 {
     Private *p = 0;
     AppointmentInterval i = a->intervalAt( row );
-    foreach ( Private *pr, m_datamap.values() ) {
+    foreach ( Private *pr, m_datamap ) {
         if ( pr->parent == a &&
             pr->type == Private::Interval &&
             i == *( static_cast<AppointmentInterval*>( pr->ptr ) ) )
@@ -1630,7 +1630,7 @@
         m_datamap.remove( const_cast<Resource*>( resource ) );
         foreach ( Appointment *a, resource->appointments( id() ) ) {
             QList<Private*> lst;
-            foreach ( Private *i, m_datamap.values() ) {
+            foreach ( Private *i, m_datamap ) {
                 if ( i->parent == a ) {
                     lst << i;
                 }
--- trunk/koffice/kplato/workpackage/part.cpp #1005924:1005925
@@ -587,7 +587,7 @@
 
 DocumentChild *Part::findChild( const Document *doc ) const
 {
-    foreach ( const WorkPackage *wp, m_packageMap.values() ) {
+    foreach ( const WorkPackage *wp, m_packageMap ) {
         DocumentChild *c = wp->findChild( doc );
         if ( c ) {
             return c;
@@ -598,7 +598,7 @@
 
 WorkPackage *Part::findWorkPackage( const Document *doc ) const
 {
-    foreach ( const WorkPackage *wp, m_packageMap.values() ) {
+    foreach ( const WorkPackage *wp, m_packageMap ) {
         if ( wp->contains( doc ) ) {
             return const_cast<WorkPackage*>( wp );
         }
@@ -608,7 +608,7 @@
 
 WorkPackage *Part::findWorkPackage( const DocumentChild *child ) const
 {
-    foreach ( const WorkPackage *wp, m_packageMap.values() ) {
+    foreach ( const WorkPackage *wp, m_packageMap ) {
         if ( wp->contains( child ) ) {
             return const_cast<WorkPackage*>( wp );
         }
@@ -736,7 +736,7 @@
         return setModified( ! clean );
     }
     bool mod = false;
-    foreach ( WorkPackage *wp, m_packageMap.values() ) {
+    foreach ( WorkPackage *wp, m_packageMap ) {
         foreach( DocumentChild *ch, wp->childDocs() ) {
             if ( ch->isModified() || ch->isFileModified() ) {
                 mod = true;
@@ -763,7 +763,7 @@
 
 bool Part::saveWorkPackages( bool silent )
 {
-    foreach ( WorkPackage *wp, m_packageMap.values() ) {
+    foreach ( WorkPackage *wp, m_packageMap ) {
         wp->saveToProjects( this );
     }
     m_undostack->setClean();
@@ -785,7 +785,7 @@
 {
     m_currentWorkPackage = 0;
     QList<WorkPackage*> modifiedList;
-    foreach ( WorkPackage *wp, m_packageMap.values() ) {
+    foreach ( WorkPackage *wp, m_packageMap ) {
         switch ( wp->queryClose( this ) ) {
             case KMessageBox::No:
                 modifiedList << wp;


[prev in list] [next in list] [prev in thread] [next in thread]