[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdesupport/emerge/bin/BuildSystem
From:       Ralf Habacker <Ralf.Habacker () freenet ! de>
Date:       2009-07-31 23:19:47
Message-ID: 1249082387.087820.20744.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1005405 by habacker:

cleanup

 M  +4 -7      BuildSystemBase.py  


--- trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py #1005404:1005405
@@ -16,8 +16,7 @@
         self.configureOptions = configureOptions
         self.makeOptions = makeOptions
                 
-    ## \todo not sure if buildType and options are used anywhere, if not remove them
-    def configure(self, buildType=None): 
+    def configure(self): 
         """configure the target"""
         abstract()
 
@@ -33,15 +32,13 @@
         """run the test - if available - for the target"""
         abstract()
 
-    def make(self, buildType=None): 
+    def make(self): 
         """make the target by runnning the related make tool"""
         abstract()
             
-    ## \todo not sure if buildType and customDefines are used anywhere, if not remove them"""
-    def compile(self, buildType=None, customOptions=""):
+    def compile(self):
         """convencience method - runs configure() and make()"""
-        ## \todo remove options
-        return self.configure( self.buildType(), customOptions ) and self.make( )
+        return self.configure() and self.make()
 
     def setDirectories(self):
         return
[prev in list] [next in list] [prev in thread] [next in thread]