From kde-commits Sun Jul 26 04:03:43 2009 From: Kevin Kofler Date: Sun, 26 Jul 2009 04:03:43 +0000 To: kde-commits Subject: Re: branches/KDE/4.3/kdelibs/kjs Message-Id: <200907260603.44562.kevin.kofler () chello ! at> X-MARC-Message: https://marc.info/?l=kde-commits&m=124858107719822 On Sunday 26 July 2009, Maksim Orlovich wrote: > On Saturday 25 July 2009 23:35:57 you wrote: > > SVN commit 1002473 by kkofler: > > > > Fix integer overflow in KJS JavaScript garbage collector (CVE-2009-1687). > > Patch adapted from WebKit changeset 41854 by Geoffrey Garen. FIXME: This > > will still crash (as in the WebKit commit), so you can still DoS the > > browser, but at least the overflow is not exploitable anymore. Backport > > revision 1002471 from trunk. > > I do not believe this overflow is possible in KJS --- see KJS_MEM_LIMIT. Interesting... I know Than Ngo patched this in RHEL for KDE 3.5.4, so somehow the folks at RH thought it exploitable at least in that old version. Though maybe they are wrong. I don't work for RH, I'm just a volunteer for Fedora, so I don't know the details. Still, does the safety check break anything? I think it certainly can't hurt to be cautious. Or will it degrade performance significantly? Kevin Kofler