[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src
From:       Dan Meltzer <parallelgrapefruit () gmail ! com>
Date:       2009-07-19 14:18:13
Message-ID: 46059ce10907190718m1b718624wfffb68a7601c0262 () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jul 19, 2009 at 5:01 AM, Alejandro
Wainzinger<aikawarazuni@gmail.com> wrote:
> Oh wow, I didn't even notice that Qt 4.4 didn't use append.  Thanks
> for the catch.

Just to clarify, 4.4 didn't have an overload of append that took a QList.
> 
> On Sun, Jul 19, 2009 at 2:46 AM, Teo Mrnjavac<teo.mrnjavac@gmail.com> wrote:
> > SVN commit 999034 by mrnjavac:
> > 
> > Make compile on Qt 4.4
> > BUG: 200609
> > 
> > M  +1 -1      collection/mediadevicecollection/CollectionCapabilityMediaDevice.cpp
> >  M  +1 -1      playlist/PlaylistSortWidget.cpp
> > 
> > 
> > --- trunk/extragear/multimedia/amarok/src/collection/mediadevicecollection/CollectionCapabilityMediaDevice.cpp \
> > #999033:999034 @@ -49,7 +49,7 @@
> > 
> > // Pull in other device actions defined by subclasses
> > 
> > -    actions.append( m_coll->handler()->collectionActions() );
> > +    actions += m_coll->handler()->collectionActions();  // This can be .append( \
> > QList<T> ) when we start depending on Qt>=4.5 
> > return actions;
> > }
> > --- trunk/extragear/multimedia/amarok/src/playlist/PlaylistSortWidget.cpp \
> > #999033:999034 @@ -38,7 +38,7 @@
> > 
> > m_comboLayout = new QHBoxLayout( this );
> > mainLayout->addLayout( m_comboLayout );
> > -    m_sortableCategories.append( internalColumnNames );
> > +    m_sortableCategories += internalColumnNames;
> > for( QStringList::iterator i = m_sortableCategories.begin(); \
> > i!=m_sortableCategories.end(); ) {
> > if( *i == QString( "Placeholder" ) || *i == QString( "Bpm" )
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]