[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform/sublime
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2009-07-19 13:57:58
Message-ID: 757d9a550907190657y7406f3d8s82b9e3a46e76d6b4 () mail ! gmail ! com
[Download RAW message or body]

I don't think it's appropiate to change all the "signals" -> "Q_SIGNALS". I
understand it's a valid test for krazy, but I don't think it adds any value
to KDevelop.

(same with the class -> module/class and so on).

On Sun, Jul 19, 2009 at 3:46 PM, Amilcar do Carmo Lucas <
amilcar@kdevelop.org> wrote:

> SVN commit 999232 by aclu:
>
> Krazy fix:
>
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdevplatform/sublime/index.html
>
>  M  +1 -1      view.h
>
>
> --- trunk/KDE/kdevplatform/sublime/view.h #999231:999232
> @@ -105,7 +105,7 @@
>  */
>  class SUBLIME_EXPORT ToolView: public View {
>     Q_OBJECT
> -signals:
> +Q_SIGNALS:
>     /**
>      * Forwarding signal, emitted when the view's widget
>      * wants to have a progress indicator shown.
>

[Attachment #3 (text/html)]

I don&#39;t think it&#39;s appropiate to change all the &quot;signals&quot; -&gt; \
&quot;Q_SIGNALS&quot;. I understand it&#39;s a valid test for krazy, but I don&#39;t \
think it adds any value to KDevelop.<br><br>(same with the class -&gt; module/class \
and so on).<br> <br><div class="gmail_quote">On Sun, Jul 19, 2009 at 3:46 PM, Amilcar \
do Carmo Lucas <span dir="ltr">&lt;<a \
href="mailto:amilcar@kdevelop.org">amilcar@kdevelop.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> SVN commit 999232 by aclu:<br>
<br>
Krazy fix:<br>
<a href="http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdevplatform/sublime/index.html" \
target="_blank">http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdevplatform/sublime/index.html</a><br>
 <br>
  M   +1 -1         view.h<br>
<br>
<br>
--- trunk/KDE/kdevplatform/sublime/view.h #999231:999232<br>
@@ -105,7 +105,7 @@<br>
   */<br>
  class SUBLIME_EXPORT ToolView: public View {<br>
       Q_OBJECT<br>
-signals:<br>
+Q_SIGNALS:<br>
       /**<br>
         * Forwarding signal, emitted when the view&#39;s widget<br>
         * wants to have a progress indicator shown.<br>
</blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]